chrome/browser/ui/views/create_application_shortcut_view.cc - Issue 12780024: Split FaviconHelper in two: ImageLoadingHelper and FaviconHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/create_application_shortcut_view.cc

Issue 12780024: Split FaviconHelper in two: ImageLoadingHelper and FaviconHelper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: similarity=20 Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/create_application_shortcut_view.cc

diff --git a/chrome/browser/ui/views/create_application_shortcut_view.cc b/chrome/browser/ui/views/create_application_shortcut_view.cc

index 20fed13df6d6a462df4abe5cba3535d79238db06..e95c6fd22cf9a4a7fb2ab76e35f9eade0a09ffc4 100644

--- a/chrome/browser/ui/views/create_application_shortcut_view.cc

+++ b/chrome/browser/ui/views/create_application_shortcut_view.cc

@@ -489,7 +489,7 @@ void CreateUrlApplicationShortcutView::FetchIcon() {

if (unprocessed_icons_.empty()) // No icons to fetch.

return;

- pending_download_id_ = web_contents_->DownloadFavicon(

+ pending_download_id_ = web_contents_->DownloadImage(

unprocessed_icons_.back().url,

true,

std::max(unprocessed_icons_.back().width,