Split FaviconHelper in two: ImageLoadingHelper and FaviconHelper

content/public/browser/web_contents.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
 
 #include "base/basictypes.h"
 #include "base/callback_forward.h"
 #include "base/process_util.h"
@@ skipping 394 matching lines @@
   // to see what it should do.
   virtual bool FocusLocationBarByDefault() = 0;
 
   // Does this have an opener associated with it?
   virtual bool HasOpener() const = 0;
 
   typedef base::Callback<void(int, /* id */
                               const GURL&, /* image_url */
                               int,  /* requested_size */
                               const std::vector<SkBitmap>& /* bitmaps*/)>
-      FaviconDownloadCallback;
+      ImageDownloadCallback;
 
-  // Sends a request to download the given favicon |url| and returns the unique
+  // Sends a request to download the given image |url| and returns the unique
   // id of the download request. When the download is finished, |callback| will
   // be called with the bitmaps received from the renderer. If [is_favicon|,

[Cait (Slow), 2013/03/28 19:10:18]

nit: [is_favicon| --> |is_favicon|
maybe also add "is true" for clarity

[Dmitry Titov, 2013/03/28 22:52:40]

Done.

   // the cookeis are not sent and not accepted during download. Note that

[Cait (Slow), 2013/03/28 19:10:18]

nit: cookeis--> cookies

[Dmitry Titov, 2013/03/28 22:52:40]

Done.

   // |image_size| is a hint for images with multiple sizes. The downloaded image
   // is not resized to the given image_size. If 0 is passed, the first frame of
   // the image is returned.
-  virtual int DownloadFavicon(const GURL& url,
-                              bool is_favicon,
-                              int image_size,
-                              const FaviconDownloadCallback& callback) = 0;
+  virtual int DownloadImage(const GURL& url,
+                            bool is_favicon,
+                            int image_size,
+                            const ImageDownloadCallback& callback) = 0;
 
  private:
   // This interface should only be implemented inside content.
   friend class WebContentsImpl;
   WebContents() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_