Split FaviconHelper in two: ImageLoadingHelper and FaviconHelper

content/renderer/render_view_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
 
 #include <deque>
 #include <map>
 #include <set>
@@ skipping 133 matching lines @@
 
 namespace content {
 class BrowserPluginManager;
 class DeviceOrientationDispatcher;
 class DevToolsAgent;
 class DocumentState;
 class DomAutomationController;
 class ExternalPopupMenu;
 class FaviconHelper;
 class GeolocationDispatcher;
+class ImageLoadingHelper;
 class InputTagSpeechDispatcher;
 class JavaBridgeDispatcher;
 class LoadProgressTracker;
 class MediaStreamDispatcher;
 class MediaStreamImpl;
 class MouseLockDispatcher;
 class NavigationState;
 class NotificationProvider;
 class RenderViewObserver;
 class RenderViewTest;
@@ skipping 1272 matching lines @@
 
   // Java Bridge dispatcher attached to this view; lazily initialized.
   JavaBridgeDispatcher* java_bridge_dispatcher_;
 
   // Mouse Lock dispatcher attached to this view.
   MouseLockDispatcher* mouse_lock_dispatcher_;
 
   // Helper class to handle favicon changes.
   FaviconHelper* favicon_helper_;
 
+  // Helper class to handle images/favicons loading.
+  ImageLoadingHelper* image_loading_helper_;

[jam, 2013/03/19 20:12:21]

no need to keep a pointer in this class since it's not being used. just create
it like other helpers and it'll delete itself when the RV is gone

[Dmitry Titov, 2013/03/20 01:30:22]

Done.

+
 #if defined(OS_ANDROID)
   // Android Specific ---------------------------------------------------------
 
   // The background color of the document body element. This is used as the
   // default background color for filling the screen areas for which we don't
   // have the actual content.
   SkColor body_background_color_;
 
   // True if SendUpdateFrameInfo is pending.
   bool update_frame_info_scheduled_;
@@ skipping 142 matching lines @@
   // use the Observer interface to filter IPC messages and receive frame change
   // notifications.
   // ---------------------------------------------------------------------------
 
   DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_