Split FaviconHelper in two: ImageLoadingHelper and FaviconHelper

content/common/icon_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message file, no traditional include guard.
 #include <vector>
 
 #include "content/public/common/favicon_url.h"
 #include "ipc/ipc_message.h"
 #include "ipc/ipc_message_macros.h"
 #include "ipc/ipc_param_traits.h"
-#include "third_party/skia/include/core/SkBitmap.h"
 
 #define IPC_MESSAGE_START IconMsgStart
 
 IPC_ENUM_TRAITS(content::FaviconURL::IconType)
 
 IPC_STRUCT_TRAITS_BEGIN(content::FaviconURL)
   IPC_STRUCT_TRAITS_MEMBER(icon_url)
   IPC_STRUCT_TRAITS_MEMBER(icon_type)
 IPC_STRUCT_TRAITS_END()
 
 // Messages sent from the browser to the renderer.
 
-// Requests the renderer to download the specified favicon image, decode it,
-// and send the image data back via IconHostMsg_DidDownloadFavicon.
-IPC_MESSAGE_ROUTED3(IconMsg_DownloadFavicon,
-                    int /* identifier for the request */,
-                    GURL /* URL of the image */,
-                    int /* Preferred favicon size. Passed on to
-                           IconHostMsg_DidDownloadFavicon, unused otherwise */)
-
 // Messages sent from the renderer to the browser.
 
 // Notification that the urls for the favicon of a site has been determined.
 IPC_MESSAGE_ROUTED2(IconHostMsg_UpdateFaviconURL,
                     int32 /* page_id */,
                     std::vector<content::FaviconURL> /* urls of the favicon */)

[jam, 2013/03/19 20:12:21]

seems too much to have one messages file for one message. especially if we move
the favicon file in content\renderer into renderviewimpl and that this message
is dispatched in WebContentsImpl, this should just move to view_messages

[Dmitry Titov, 2013/03/20 01:30:22]

moved to view_messages, removed FaviconHelper class.

-
-IPC_MESSAGE_ROUTED4(IconHostMsg_DidDownloadFavicon,
-                    int /* Identifier of the request */,
-                    GURL /* URL of the image */,
-                    int /* Preferred icon size passed to
-                           IconMsg_DownloadFavicon */,
-                    std::vector<SkBitmap> /* image_data */)