Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 12780019: Merge 145954 "TextIterator emits LF for a br element inside an e..." (Closed)

Created:
7 years, 9 months ago by aelias_OOO_until_Jul13
Modified:
7 years, 9 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Merge 145954 "TextIterator emits LF for a br element inside an e..." > TextIterator emits LF for a br element inside an empty input element > https://bugs.webkit.org/show_bug.cgi?id=112275 > > Patch by Aurimas Liutikas <aurimas@chromium.org>; on 2013-03-15 > Reviewed by Ryosuke Niwa. > > Source/WebCore: > > Adding a check to avoid emiting LF for br elements inside a shadow tree > of an input element. > > Test: editing/text-iterator/basic-iteration.html > editing/text-iterator/basic-iteration-shadowdom.html > > * editing/TextIterator.cpp: > (WebCore::shouldEmitNewlineForNode): > (WebCore::TextIterator::handleNonTextNode): > (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): > (WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode): > (WebCore::SimplifiedBackwardsTextIterator::exitNode): > * editing/TextIterator.h: > (SimplifiedBackwardsTextIterator): > > LayoutTests: > > * editing/text-iterator/basic-iteration-expected.txt: Extended to add two more cases. > * editing/text-iterator/basic-iteration-shadowdom-expected.txt: Added. > * editing/text-iterator/basic-iteration-shadowdom.html: Added. > * editing/text-iterator/script-tests/basic-iteration.js: Extended to add two mroe cases. > * platform/mac/TestExpectations: TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146099

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7630 lines, -8 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +7598 lines, -0 lines 0 comments Download
M LayoutTests/editing/text-iterator/basic-iteration-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A + LayoutTests/editing/text-iterator/basic-iteration-shadowdom.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/editing/text-iterator/basic-iteration-shadowdom-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/editing/text-iterator/script-tests/basic-iteration.js View 2 chunks +17 lines, -0 lines 0 comments Download
M LayoutTests/platform/mac/TestExpectations View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/editing/TextIterator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebCore/editing/TextIterator.cpp View 6 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
aelias_OOO_until_Jul13
7 years, 9 months ago (2013-03-18 19:02:49 UTC) #1
aelias_OOO_until_Jul13
7 years, 9 months ago (2013-03-18 19:03:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r146099.

Powered by Google App Engine
This is Rietveld 408576698