Issue 12780016: Revert 188747 "Android WebView: change how the SDK jar is found."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12780016: Revert 188747 "Android WebView: change how the SDK jar is found." (Closed)

Created:
7 years, 9 months ago by Torne

Modified:
7 years, 9 months ago

Reviewers:
Torne

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 188747 "Android WebView: change how the SDK jar is found." > Android WebView: change how the SDK jar is found. > > Setting android_sdk has unintended consequences which have recently > broken the build, but we still need to be able to point to the sdk > jarfile for now until this dependency has been solved for real; use the > newly introduced android_sdk_jar variable from r188737 to specify this > and set android_sdk to a harmless but invalid value rather than a make > variable expansion. > > BUG= > > Review URL: https://codereview.chromium.org/12917006 TBR=torne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188769

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	build/android/envsetup_functions.sh	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r188769.

Expand Messages | Collapse Messages