chrome/browser/webdata/web_data_service.h - Issue 12780012: Move UI dependency from WebDataService to WebDataServiceFactory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/webdata/web_data_service.h

Issue 12780012: Move UI dependency from WebDataService to WebDataServiceFactory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add missing 'explicit' on constructor, fix win unit test. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/webdata/web_data_service.h

diff --git a/chrome/browser/webdata/web_data_service.h b/chrome/browser/webdata/web_data_service.h

index a21ad3dab0615cd3fe5b6fa74086a19f3904b8de..9eabe679c15f6e97358207e1307e9138ff9c2008 100644

--- a/chrome/browser/webdata/web_data_service.h

+++ b/chrome/browser/webdata/web_data_service.h

@@ -107,7 +107,7 @@ class WebDataService

static scoped_refptr<WebDataService> FromBrowserContext(

content::BrowserContext* context);

- WebDataService();

+ explicit WebDataService(const ProfileErrorCallback& callback);

// WebDataServiceBase implementation.

virtual void ShutdownOnUIThread() OVERRIDE;

@@ -306,6 +306,9 @@ class WebDataService

friend class WebDataServiceTest;

friend class WebDataRequest;

+ // For unit tests, passes a null callback.

+ WebDataService();

virtual ~WebDataService();

//////////////////////////////////////////////////////////////////////////////