Move UI dependency from WebDataService to WebDataServiceFactory.

components/autofill/browser/autocomplete_history_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/memory/ref_counted.h"
 #include "base/prefs/testing_pref_service.h"
 #include "base/string16.h"
 #include "base/utf_string_conversions.h"
@@ skipping 14 matching lines @@
 #include "ui/gfx/rect.h"
 
 using content::BrowserThread;
 using content::WebContents;
 using testing::_;
 
 namespace {
 
 class MockWebDataService : public WebDataService {
  public:
-  MockWebDataService() {
+  MockWebDataService()
+      : WebDataService(WebDataServiceBase::ProfileErrorCallback()) {

[Cait (Slow), 2013/03/18 16:16:37]

I wonder if it's worth having a default ctor on WDS that constructs the WDS with
a NULL callback (and  eventually a NULL WebDatabaseService), to avoid
continually having to touch these same unit_tests?

[Jói, 2013/03/18 23:21:23]

Added such a protected constructor, so mock versions of WebDataService don't
need to specify this.

     current_mock_web_data_service_ = this;
   }
 
   MOCK_METHOD1(AddFormFields, void(const std::vector<FormFieldData>&));
 
   static scoped_refptr<MockWebDataService> GetCurrent() {
     if (!current_mock_web_data_service_) {
       return new MockWebDataService();
     }
     return current_mock_web_data_service_;
@@ skipping 207 matching lines @@
   AutofillManager::CreateForWebContentsAndDelegate(
       web_contents(), &manager_delegate);
 
   MockAutofillExternalDelegate external_delegate(web_contents());
   autocomplete_history_manager.SetExternalDelegate(&external_delegate);
 
   // Should trigger a call to OnSuggestionsReturned, verified by the mock.
   EXPECT_CALL(external_delegate, OnSuggestionsReturned(_, _, _, _, _));
   autocomplete_history_manager.SendSuggestions(NULL);
 }