Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 12780007: IndexedDB: Add performance test calling continue(key) (Closed)

Created:
7 years, 9 months ago by jsbell
Modified:
7 years, 9 months ago
Reviewers:
ericu, alecflett, dgrogan
CC:
chromium-reviews
Visibility:
Public.

Description

IndexedDB: Add performance test calling continue(key) Upcoming patch http://wkbug.com/109972 changes this from a linear walk to a seek (log N, presumably) NOTRY=true BUG=175172 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188754

Patch Set 1 #

Total comments: 3

Patch Set 2 : Incorporate review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -0 lines) Patch
M chrome/test/data/indexeddb/perf_test.js View 1 2 chunks +69 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jsbell
dgrogan@, ericu@ - please take a look? Pre-webkit patch I see times around 100ms/300ms. After ...
7 years, 9 months ago (2013-03-15 19:44:12 UTC) #1
dgrogan
lgtm https://codereview.chromium.org/12780007/diff/1/chrome/test/data/indexeddb/perf_test.js File chrome/test/data/indexeddb/perf_test.js (right): https://codereview.chromium.org/12780007/diff/1/chrome/test/data/indexeddb/perf_test.js#newcode635 chrome/test/data/indexeddb/perf_test.js:635: console.log("created: " + testName); Unintentional? https://codereview.chromium.org/12780007/diff/1/chrome/test/data/indexeddb/perf_test.js#newcode654 chrome/test/data/indexeddb/perf_test.js:654: var ...
7 years, 9 months ago (2013-03-16 00:49:51 UTC) #2
jsbell
> https://codereview.chromium.org/12780007/diff/1/chrome/test/data/indexeddb/perf_test.js#newcode635 > chrome/test/data/indexeddb/perf_test.js:635: console.log("created: " + > testName); > Unintentional? > Oops, thanks. > ...
7 years, 9 months ago (2013-03-17 06:13:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/12780007/6001
7 years, 9 months ago (2013-03-18 16:40:11 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-18 16:50:05 UTC) #5
Message was sent while issue was closed.
Change committed as 188754

Powered by Google App Engine
This is Rietveld 408576698