build/android/pylib/remote/device/remote_device_gtest_run.py - Issue 1277943002: [Android] Detect when remote service loses contact with device.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/remote/device/remote_device_gtest_run.py

Issue 1277943002: [Android] Detect when remote service loses contact with device. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | build/android/pylib/remote/device/remote_device_test_run.py » ('j') | build/android/pylib/remote/device/remote_device_test_run.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/pylib/remote/device/remote_device_gtest_run.py

diff --git a/build/android/pylib/remote/device/remote_device_gtest_run.py b/build/android/pylib/remote/device/remote_device_gtest_run.py

index 7a49e96bae5ec1d715cbc4a43542561db979977b..c547fff287533b668f116a94e10fd04055b7b844 100644

--- a/build/android/pylib/remote/device/remote_device_gtest_run.py

+++ b/build/android/pylib/remote/device/remote_device_gtest_run.py

@@ -82,6 +82,10 @@ class RemoteDeviceGtestTestRun(remote_device_test_run.RemoteDeviceTestRun):

results.AddResult(base_test_result.BaseTestResult(

'Remote Service detected native crash.',

base_test_result.ResultType.CRASH))

+ elif self._DidDeviceGoOffline():

+ self._LogLogcat()

+ raise remote_device_helper.RemoteDeviceError(

+ 'Remote service unable to reach device.', is_infra_error=True)

else:

results.AddResult(base_test_result.BaseTestResult(

'Remote Service detected error.',

« no previous file with comments | « no previous file | build/android/pylib/remote/device/remote_device_test_run.py » ('j') | build/android/pylib/remote/device/remote_device_test_run.py » ('J')