[Android] Detect when remote service loses contact with device.

[Android] Detect when remote service loses contact with device.

Sometimes the service will lose communication with device.

BUG=512305
Committed: https://crrev.com/e88efeb36d6bd3074f1c6ec003137efd809999b9
Cr-Commit-Position: refs/heads/master@{#342666}

[rnephew (Reviews Here), 2015-08-06 16:19:54]

Example of bad adb_trace.log:

1521 KB/s (56614 bytes in 0.036s)
0 files pushed. 0 files skipped.
0 files pushed. 0 files skipped.
2038 KB/s (6266928 bytes in 3.001s)
push: /tmp/testrun_498042/testfiles/paks/en-US.pak -> /sdcard/paks/en-US.pak
1 file pushed. 0 files skipped.
1762 KB/s (157595 bytes in 0.087s)
3 KB/s (174 bytes in 0.042s)
1935 KB/s (7950547 bytes in 4.011s)
error: device not found
error: device not found
error: device not found
error: device not found
error: device not found
error: device not found
error: device not found
error: device not found
error: device not found
error: device not found
error: device not found
error: device not found
error: device not found
error: device not found
error: device not found
- waiting for device -

[rnephew (Reviews Here), 2015-08-06 16:20:15]

rnephew@chromium.org changed reviewers:
+ jbudorick@chromium.org, mikecase@chromium.org

[jbudorick, 2015-08-06 16:31:36]

https://codereview.chromium.org/1277943002/diff/1/build/android/pylib/remote/...
File build/android/pylib/remote/device/remote_device_test_run.py (right):

https://codereview.chromium.org/1277943002/diff/1/build/android/pylib/remote/...
build/android/pylib/remote/device/remote_device_test_run.py:340:
logging.log(level, '---Logging remote device logcat---')
+1

https://codereview.chromium.org/1277943002/diff/1/build/android/pylib/remote/...
build/android/pylib/remote/device/remote_device_test_run.py:348: device_offline
= re.compile('error: device not found')
This should be compiled into a constant at module scope.

https://codereview.chromium.org/1277943002/diff/1/build/android/pylib/remote/...
build/android/pylib/remote/device/remote_device_test_run.py:353:
logging.critical('---Logging remote device adb trace log---')
The function name doesn't imply anything about logging, and it's inconsistent
with how we handle the logcat. I would prefer doing this in a separate function.

[rnephew (Reviews Here), 2015-08-06 16:42:07]

https://codereview.chromium.org/1277943002/diff/1/build/android/pylib/remote/...
File build/android/pylib/remote/device/remote_device_test_run.py (right):

https://codereview.chromium.org/1277943002/diff/1/build/android/pylib/remote/...
build/android/pylib/remote/device/remote_device_test_run.py:340:
logging.log(level, '---Logging remote device logcat---')
On 2015/08/06 16:31:36, jbudorick wrote:
> +1

Done.

https://codereview.chromium.org/1277943002/diff/1/build/android/pylib/remote/...
build/android/pylib/remote/device/remote_device_test_run.py:348: device_offline
= re.compile('error: device not found')
On 2015/08/06 16:31:36, jbudorick wrote:
> This should be compiled into a constant at module scope.

Done.

https://codereview.chromium.org/1277943002/diff/1/build/android/pylib/remote/...
build/android/pylib/remote/device/remote_device_test_run.py:353:
logging.critical('---Logging remote device adb trace log---')
On 2015/08/06 16:31:36, jbudorick wrote:
> The function name doesn't imply anything about logging, and it's inconsistent
> with how we handle the logcat. I would prefer doing this in a separate
function.

Done.

[jbudorick, 2015-08-10 18:07:05]

lgtm

https://codereview.chromium.org/1277943002/diff/20001/build/android/pylib/rem...
File build/android/pylib/remote/device/remote_device_gtest_run.py (right):

https://codereview.chromium.org/1277943002/diff/20001/build/android/pylib/rem...
build/android/pylib/remote/device/remote_device_gtest_run.py:86:
self._LogLogcat()
Again, I think we want to get to a state where we have a failed amp step look
like this on a bot:

  [collect] my_test_suite
    1. stdio
    2. logcat
    3. adb_trace.log

[rnephew (Reviews Here), 2015-08-10 18:12:36]

The CQ bit was checked by rnephew@chromium.org

[commit-bot: I haz the power, 2015-08-10 18:13:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1277943002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1277943002/20001

[commit-bot: I haz the power, 2015-08-10 19:18:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-10 19:19:18]

Patchset 2 (id:??) landed as
https://crrev.com/e88efeb36d6bd3074f1c6ec003137efd809999b9
Cr-Commit-Position: refs/heads/master@{#342666}