Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: components/scheduler/child/task_queue_sets.cc

Issue 1277923002: Revert of Explicitly track the scheduler task enqueueing order in a new field (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/scheduler/child/task_queue_sets.h" 5 #include "components/scheduler/child/task_queue_sets.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "components/scheduler/child/task_queue_impl.h" 8 #include "components/scheduler/child/task_queue_impl.h"
9 9
10 namespace scheduler { 10 namespace scheduler {
11 namespace internal { 11 namespace internal {
12 12
13 TaskQueueSets::TaskQueueSets(size_t num_sets) 13 TaskQueueSets::TaskQueueSets(size_t num_sets) : age_to_queue_maps_(num_sets) {}
14 : enqueue_order_to_queue_maps_(num_sets) {}
15 14
16 TaskQueueSets::~TaskQueueSets() {} 15 TaskQueueSets::~TaskQueueSets() {}
17 16
18 void TaskQueueSets::RemoveQueue(internal::TaskQueueImpl* queue) { 17 void TaskQueueSets::RemoveQueue(internal::TaskQueueImpl* queue) {
19 int enqueue_order; 18 int age;
20 bool has_enqueue_order = 19 bool has_age = queue->GetWorkQueueFrontTaskAge(&age);
21 queue->GetWorkQueueFrontTaskEnqueueOrder(&enqueue_order); 20 if (!has_age)
22 if (!has_enqueue_order)
23 return; 21 return;
24 size_t set_index = queue->get_task_queue_set_index(); 22 size_t set_index = queue->get_task_queue_set_index();
25 DCHECK_LT(set_index, enqueue_order_to_queue_maps_.size()); 23 DCHECK_LT(set_index, age_to_queue_maps_.size());
26 enqueue_order_to_queue_maps_[set_index].erase(enqueue_order); 24 age_to_queue_maps_[set_index].erase(age);
27 } 25 }
28 26
29 void TaskQueueSets::AssignQueueToSet(internal::TaskQueueImpl* queue, 27 void TaskQueueSets::AssignQueueToSet(internal::TaskQueueImpl* queue,
30 size_t set_index) { 28 size_t set_index) {
31 DCHECK_LT(set_index, enqueue_order_to_queue_maps_.size()); 29 DCHECK_LT(set_index, age_to_queue_maps_.size());
32 int enqueue_order; 30 int age;
33 bool has_enqueue_order = 31 bool has_age = queue->GetWorkQueueFrontTaskAge(&age);
34 queue->GetWorkQueueFrontTaskEnqueueOrder(&enqueue_order);
35 size_t old_set = queue->get_task_queue_set_index(); 32 size_t old_set = queue->get_task_queue_set_index();
36 DCHECK_LT(old_set, enqueue_order_to_queue_maps_.size()); 33 DCHECK_LT(old_set, age_to_queue_maps_.size());
37 queue->set_task_queue_set_index(set_index); 34 queue->set_task_queue_set_index(set_index);
38 if (!has_enqueue_order) 35 if (!has_age)
39 return; 36 return;
40 enqueue_order_to_queue_maps_[old_set].erase(enqueue_order); 37 age_to_queue_maps_[old_set].erase(age);
41 enqueue_order_to_queue_maps_[set_index].insert( 38 age_to_queue_maps_[set_index].insert(std::make_pair(age, queue));
42 std::make_pair(enqueue_order, queue));
43 } 39 }
44 40
45 void TaskQueueSets::OnPushQueue(internal::TaskQueueImpl* queue) { 41 void TaskQueueSets::OnPushQueue(internal::TaskQueueImpl* queue) {
46 int enqueue_order; 42 int age;
47 bool has_enqueue_order = 43 bool has_age = queue->GetWorkQueueFrontTaskAge(&age);
48 queue->GetWorkQueueFrontTaskEnqueueOrder(&enqueue_order); 44 DCHECK(has_age);
49 DCHECK(has_enqueue_order);
50 size_t set_index = queue->get_task_queue_set_index(); 45 size_t set_index = queue->get_task_queue_set_index();
51 DCHECK_LT(set_index, enqueue_order_to_queue_maps_.size()) << " set_index = " 46 DCHECK_LT(set_index, age_to_queue_maps_.size()) << " set_index = "
52 << set_index; 47 << set_index;
53 enqueue_order_to_queue_maps_[set_index].insert( 48 age_to_queue_maps_[set_index].insert(std::make_pair(age, queue));
54 std::make_pair(enqueue_order, queue));
55 } 49 }
56 50
57 void TaskQueueSets::OnPopQueue(internal::TaskQueueImpl* queue) { 51 void TaskQueueSets::OnPopQueue(internal::TaskQueueImpl* queue) {
58 size_t set_index = queue->get_task_queue_set_index(); 52 size_t set_index = queue->get_task_queue_set_index();
59 DCHECK_LT(set_index, enqueue_order_to_queue_maps_.size()); 53 DCHECK_LT(set_index, age_to_queue_maps_.size());
60 DCHECK(!enqueue_order_to_queue_maps_[set_index].empty()) << " set_index = " 54 DCHECK(!age_to_queue_maps_[set_index].empty()) << " set_index = "
61 << set_index; 55 << set_index;
62 DCHECK_EQ(enqueue_order_to_queue_maps_[set_index].begin()->second, queue) 56 DCHECK_EQ(age_to_queue_maps_[set_index].begin()->second, queue)
63 << " set_index = " << set_index; 57 << " set_index = " << set_index;
64 // O(1) amortised. 58 // O(1) amortised.
65 enqueue_order_to_queue_maps_[set_index].erase( 59 age_to_queue_maps_[set_index].erase(age_to_queue_maps_[set_index].begin());
66 enqueue_order_to_queue_maps_[set_index].begin()); 60 int age;
67 int enqueue_order; 61 bool has_age = queue->GetWorkQueueFrontTaskAge(&age);
68 bool has_enqueue_order = 62 if (!has_age)
69 queue->GetWorkQueueFrontTaskEnqueueOrder(&enqueue_order);
70 if (!has_enqueue_order)
71 return; 63 return;
72 enqueue_order_to_queue_maps_[set_index].insert( 64 age_to_queue_maps_[set_index].insert(std::make_pair(age, queue));
73 std::make_pair(enqueue_order, queue));
74 } 65 }
75 66
76 bool TaskQueueSets::GetOldestQueueInSet( 67 bool TaskQueueSets::GetOldestQueueInSet(
77 size_t set_index, 68 size_t set_index,
78 internal::TaskQueueImpl** out_queue) const { 69 internal::TaskQueueImpl** out_queue) const {
79 DCHECK_LT(set_index, enqueue_order_to_queue_maps_.size()); 70 DCHECK_LT(set_index, age_to_queue_maps_.size());
80 if (enqueue_order_to_queue_maps_[set_index].empty()) 71 if (age_to_queue_maps_[set_index].empty())
81 return false; 72 return false;
82 *out_queue = enqueue_order_to_queue_maps_[set_index].begin()->second; 73 *out_queue = age_to_queue_maps_[set_index].begin()->second;
83 return true; 74 return true;
84 } 75 }
85 76
86 } // namespace internal 77 } // namespace internal
87 } // namespace scheduler 78 } // namespace scheduler
OLDNEW
« no previous file with comments | « components/scheduler/child/task_queue_sets.h ('k') | components/scheduler/child/task_queue_sets_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698