Add Ash notification UI for OutOfCredits network property

Add Ash notification UI for OutOfCredits network property


BUG=177240
for ash.gyp, ash/ash_chromeos_strings.grdp
TBR=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189051

[Greg Spencer (Chromium), 2013-03-18 22:12:46]

LGTM.

It's too bad that "out of credits" is a boolean: seems like something we'd want
to know a value for so that when we were getting close we could change the UI to
indicate that.  But I realize that is on the Shill side.

[stevenjb, 2013-03-18 22:44:41]

Agreed, but, with the new UI we could pretty easily add a new property in Shill,
then replace the existing one with the new one in a single, relatively small CL.

[stevenjb, 2013-03-18 22:46:25]

PTAL (at the deltas)

I added code to support R26 (which doesn't have NetworkStateNotifier). I put the
R26 support behind --ash-disable-new-network-status-area in ToT, so that when we
merge we will just:
1. Remove references to the flag (which doesn't exist)
2. Ignore the changes to NetworkStateNotifier (which also doesn't exist)

[Greg Spencer (Chromium), 2013-03-18 22:49:46]

On 2013/03/18 22:46:25, stevenjb (chromium) wrote:
> PTAL (at the deltas)
> 
> I added code to support R26 (which doesn't have NetworkStateNotifier). I put
the
> R26 support behind --ash-disable-new-network-status-area in ToT, so that when
we
> merge we will just:
> 1. Remove references to the flag (which doesn't exist)
> 2. Ignore the changes to NetworkStateNotifier (which also doesn't exist)

still LGTM.

[jennyz, 2013-03-18 23:11:50]

lgtm

[commit-bot: I haz the power, 2013-03-19 00:41:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/12779022/8001

[commit-bot: I haz the power, 2013-03-19 00:41:21]

Presubmit check for 12779022-8001 failed and returned exit status 1.

INFO:root:Found 15 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/ash/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    ash/ash_chromeos_strings.grdp
    ash/ash.gyp

Presubmit checks took 1.6s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2013-03-19 00:46:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/12779022/8001

[commit-bot: I haz the power, 2013-03-19 03:03:41]

Retried try job too often on win_rel for step(s) sync_integration_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[stevenjb, 2013-03-19 17:28:27]

Committed patchset #3 manually as r189051 (presubmit successful).