Let SkWebpCodec decode to 565

Let SkWebpCodec decode to 565

BUG=skia:3257
Committed: https://skia.googlesource.com/skia/+/74992b579422a5e31fa07705d1f9206e0d919706

[scroggo_chromium, 2015-08-06 18:30:52]

scroggo@chromium.org changed reviewers:
+ emmaleer@google.com, msarett@google.com

[msarett, 2015-08-06 19:30:03]

lgtm

https://codereview.chromium.org/1277893002/diff/1/src/codec/SkWebpCodec.cpp
File src/codec/SkWebpCodec.cpp (right):

https://codereview.chromium.org/1277893002/diff/1/src/codec/SkWebpCodec.cpp#n...
src/codec/SkWebpCodec.cpp:96: {
nit: I think the bracket should go on the previous line?

[scroggo, 2015-08-06 20:42:44]

scroggo@google.com changed reviewers:
+ scroggo@google.com

[scroggo, 2015-08-06 20:42:44]

https://codereview.chromium.org/1277893002/diff/1/src/codec/SkWebpCodec.cpp
File src/codec/SkWebpCodec.cpp (right):

https://codereview.chromium.org/1277893002/diff/1/src/codec/SkWebpCodec.cpp#n...
src/codec/SkWebpCodec.cpp:96: {
On 2015/08/06 19:30:03, msarett wrote:
> nit: I think the bracket should go on the previous line?

Maybe? In general the { does not get its own line, but we do not have hard and
fast rules about what to do when line breaking a conditional. If that all fit on
one line, I would have said:

if (condition) {
  // code

With it on two lines, I could indent the following line 8 spaces:

if (long condition...
        && other condition) {
    // code

Or I can line up with the "(" -

if (long condition...
    && other condtion) {
    // code...

In that last version, the code lines up with the second part of the condition,
so I moved the brace to its own line. IMO that is more readable than the other
options.

[scroggo, 2015-08-06 20:42:47]

The CQ bit was checked by scroggo@google.com

[commit-bot: I haz the power, 2015-08-06 20:43:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1277893002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1277893002/1

[commit-bot: I haz the power, 2015-08-06 20:50:19]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/74992b579422a5e31fa07705d1f9206e0d919706