[PresentationAPI,Android] Implement the ChromeMediaRouterDialogController.

[PresentationAPI,Android] Implement the ChromeMediaRouterDialogController.

BUG=517101
TEST=https://avayvod.github.io/presentationapitest.html shows the dialog when "start session" is tapped.

Committed: https://crrev.com/1834c874439be0013b526731ef2f28dc24f8f36f
Cr-Commit-Position: refs/heads/master@{#342443}

[whywhat, 2015-08-06 17:47:49]

avayvod@chromium.org changed reviewers:
+ mlamouri@chromium.org

[whywhat, 2015-08-06 17:47:50]

PTaL

[mlamouri (slow - plz ping), 2015-08-07 10:42:27]

lgtm, with my little knowledge of that code.

https://codereview.chromium.org/1277883003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouterDialogController.java
(right):

https://codereview.chromium.org/1277883003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouterDialogController.java:31:

nit: remove empty line?

https://codereview.chromium.org/1277883003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSourceUrn.java
(right):

https://codereview.chromium.org/1277883003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSourceUrn.java:27:
public static CastSourceUrn from(String sourceUrn) {
I'm no Java expert but wouldn't that be better as annotating the parameter?

https://codereview.chromium.org/1277883003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSourceUrn.java:59:
if (parameter.startsWith(CAST_SOURCE_URN_APPLICATION_ID_PREFIX)) {
if (!parameter.startsWith(CAST_SOURCE_URN_APPLICATION_ID_PREFIX)) continue;

[whywhat, 2015-08-07 20:50:59]

https://codereview.chromium.org/1277883003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouterDialogController.java
(right):

https://codereview.chromium.org/1277883003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/router/ChromeMediaRouterDialogController.java:31:

On 2015/08/07 at 10:42:26, Mounir Lamouri wrote:
> nit: remove empty line?

Done.

https://codereview.chromium.org/1277883003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSourceUrn.java
(right):

https://codereview.chromium.org/1277883003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSourceUrn.java:27:
public static CastSourceUrn from(String sourceUrn) {
On 2015/08/07 at 10:42:26, Mounir Lamouri wrote:
> I'm no Java expert but wouldn't that be better as annotating the parameter?

Done.

https://codereview.chromium.org/1277883003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CastSourceUrn.java:59:
if (parameter.startsWith(CAST_SOURCE_URN_APPLICATION_ID_PREFIX)) {
On 2015/08/07 at 10:42:26, Mounir Lamouri wrote:
> if (!parameter.startsWith(CAST_SOURCE_URN_APPLICATION_ID_PREFIX)) continue;

I anticipate parsing other parameters in the future, then the current code
structure is more preferable.

[whywhat, 2015-08-07 20:51:10]

The CQ bit was checked by avayvod@chromium.org

[whywhat, 2015-08-07 20:51:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/1277883003/#ps40001
(title: "Corrected Cast URN domain and close the dialog fragment upon dialog
dismissal.")

[commit-bot: I haz the power, 2015-08-07 20:51:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1277883003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1277883003/40001

[commit-bot: I haz the power, 2015-08-07 21:34:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-07 21:35:10]

Patchset 3 (id:??) landed as
https://crrev.com/1834c874439be0013b526731ef2f28dc24f8f36f
Cr-Commit-Position: refs/heads/master@{#342443}