Fix stale entries in optimized code map.

Fix stale entries in optimized code map.

This fixes a corner-case where extending an optimized code map left
stale entries in the abandoned copy. This can cause havoc not only in
the heap verifier but also in the GC, because stale entries have not
been recorded when being trated weakly.

Note that this also pre-tenures all optimized code maps into old-space
because their lifetime is coupled to the SharedFunctionInfo anyways.

R=hpayer@chromium.org
TEST=cctest/test-heap/Regress514122
BUG=chromium:514122
LOG=N

Committed: https://crrev.com/d4ac509f3cdcd22523ad2df64ec69d9cda370887
Cr-Commit-Position: refs/heads/master@{#30047}

[Hannes Payer (out of office), 2015-08-06 12:27:31]

Cool! lgtm

https://codereview.chromium.org/1277873002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1277873002/diff/1/src/objects.cc#newcode9521
src/objects.cc:9521: new_code_map =
isolate->factory()->NewFixedArray(kInitialLength, TENURED);
Good!

https://codereview.chromium.org/1277873002/diff/1/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):

https://codereview.chromium.org/1277873002/diff/1/test/cctest/test-heap.cc#ne...
test/cctest/test-heap.cc:4633: // Add the code several times to the optimized
code map. This will leave some
remove some

[nicole, 2015-08-06 12:28:21]

nicolebilbao29@gmail.com changed reviewers:
+ nicolebilbao29@gmail.com

[Michael Starzinger, 2015-08-06 13:55:29]

https://codereview.chromium.org/1277873002/diff/1/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):

https://codereview.chromium.org/1277873002/diff/1/test/cctest/test-heap.cc#ne...
test/cctest/test-heap.cc:4633: // Add the code several times to the optimized
code map. This will leave some
On 2015/08/06 12:27:30, Hannes Payer wrote:
> remove some

Done.

[Michael Starzinger, 2015-08-06 13:59:11]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2015-08-06 13:59:11]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1277873002/#ps20001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2015-08-06 13:59:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1277873002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1277873002/20001

[commit-bot: I haz the power, 2015-08-06 14:22:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-06 14:22:28]

Patchset 2 (id:??) landed as
https://crrev.com/d4ac509f3cdcd22523ad2df64ec69d9cda370887
Cr-Commit-Position: refs/heads/master@{#30047}