Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 1277803004: Revert of Elements whose contents start with an astral Unicode symbol disappear when CSS `::first-letter` is … (Closed)

Created:
5 years, 4 months ago by sof
Modified:
5 years, 4 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Elements whose contents start with an astral Unicode symbol disappear when CSS `::first-letter` is … (patchset #9 id:160001 of https://codereview.chromium.org/1133853006/ ) Reason for revert: ASan picking up a number of UAF failures due to this one, http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/builds/19782 Original issue's description: > Elements whose contents start with an astral Unicode symbol disappear when CSS `::first-letter` is applied to them. > > This CL is inspired by http://trac.webkit.org/changeset/172513 > written by Myles C. Maxfield. > The previous code assumed that all "characters" are exactly 1 16-bit code unit wide. > Instead, use numCharactersInGraphemeClusters(). > > For blink, we add countCharactersAndGraphemesInCluster to bring a similar > functionality to blink. This api is based on countGraphemesInCluster and improved > to figure out the number of characters and grapheme at the same time in the given clusters. > > BUG=401945 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200227 TBR=leviw@chromium.org,eae@chromium.org,esprehn@chromium.org,drott@chromium.org,shivamidow@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=401945 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200228

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -52 lines) Patch
D LayoutTests/css1/pseudo/firstletter-surrogate.html View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/css1/pseudo/firstletter-surrogate-expected.html View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/dom/FirstLetterPseudoElement.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M Source/platform/fonts/shaping/HarfBuzzShaper.cpp View 2 chunks +22 lines, -1 line 0 comments Download
M Source/platform/text/TextBreakIterator.h View 2 chunks +0 lines, -11 lines 0 comments Download
M Source/platform/text/TextBreakIterator.cpp View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sof
5 years, 4 months ago (2015-08-09 12:54:45 UTC) #1
Created Revert of Elements whose contents start with an astral Unicode symbol
disappear when CSS `::first-letter` is …

Powered by Google App Engine
This is Rietveld 408576698