Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1277693004: [runtime] Remove unused %ToBool runtime function. (Closed)

Created:
5 years, 4 months ago by Benedikt Meurer
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Remove unused %ToBool runtime function. R=yangguo@chromium.org Committed: https://crrev.com/0e5ec1b9102a61a8da51227369b5bb5fdd04edbc Cr-Commit-Position: refs/heads/master@{#30085}

Patch Set 1 #

Patch Set 2 : Didn't mean to remove this comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24 lines) Patch
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M test/cctest/compiler/test-run-jscalls.cc View 1 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 4 months ago (2015-08-10 09:58:13 UTC) #1
Benedikt Meurer
Hey Yang, Obvious one. Please take a look. Thanks, Benedikt
5 years, 4 months ago (2015-08-10 09:59:03 UTC) #2
Yang
On 2015/08/10 09:59:03, Benedikt Meurer wrote: > Hey Yang, > > Obvious one. Please take ...
5 years, 4 months ago (2015-08-10 09:59:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277693004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277693004/20001
5 years, 4 months ago (2015-08-10 10:31:16 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-10 10:32:47 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 10:33:08 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/0e5ec1b9102a61a8da51227369b5bb5fdd04edbc
Cr-Commit-Position: refs/heads/master@{#30085}

Powered by Google App Engine
This is Rietveld 408576698