Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1277683005: Turning return by const value to return by const ref in BirthOnThread::location() (Closed)

Created:
5 years, 4 months ago by Paritosh Kumar
Modified:
5 years, 4 months ago
Reviewers:
danakj, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turning return by const value to return by const ref in BirthOnThread::location() BUG=393155 Committed: https://crrev.com/054866a1f5dde14485efc3fb7f63e5eeb0ff2545 Cr-Commit-Position: refs/heads/master@{#342421}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/tracked_objects.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Paritosh Kumar
Please have a look.
5 years, 4 months ago (2015-08-07 10:27:32 UTC) #2
danakj
That looks like what was intended. LGTM
5 years, 4 months ago (2015-08-07 18:30:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277683005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277683005/1
5 years, 4 months ago (2015-08-07 18:57:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 20:05:44 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 20:06:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/054866a1f5dde14485efc3fb7f63e5eeb0ff2545
Cr-Commit-Position: refs/heads/master@{#342421}

Powered by Google App Engine
This is Rietveld 408576698