Chromium Code Reviews

Issue 1277663002: Allow only one bookmark to be added for multiple fast starring (Closed)

Created:
5 years, 4 months ago by Ian Wen
Modified:
5 years, 4 months ago
Reviewers:
CC:
chromium-reviews, ianwen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2454
Target Ref:
refs/pending/branch-heads/2454
Project:
chromium
Visibility:
Public.

Description

Allow only one bookmark to be added for multiple fast starring A quick user might be able to save duplicated bookmarks when he clicks the star button before the bookmark model is loaded yet. This CL forces that only one operation can be done before the model is loaded. BUG=516658 Review URL: https://codereview.chromium.org/1263223005 Cr-Commit-Position: refs/heads/master@{#341976} TBR=newt@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/153ab395bae50244b32eeae4c0f98b69d1fd22eb

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+30 lines, -28 lines)
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 3 chunks +14 lines, -21 lines 0 comments
M chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkUtils.java View 4 chunks +16 lines, -7 lines 0 comments

Messages

Total messages: 1 (0 generated)
Ian Wen
5 years, 4 months ago (2015-08-05 23:27:31 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
153ab395bae50244b32eeae4c0f98b69d1fd22eb (presubmit successful).

Powered by Google App Engine