Make allocation of Dart parameters and local variables architecture independent.

runtime/vm/parser.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/parser.h"
 
 #include "lib/invocation_mirror.h"
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
@@ skipping 140 matching lines @@
 
 
 void ParsedFunction::AllocateVariables() {
   LocalScope* scope = node_sequence()->scope();
   const intptr_t num_fixed_params = function().num_fixed_parameters();
   const intptr_t num_opt_params = function().NumOptionalParameters();
   intptr_t num_params = num_fixed_params + num_opt_params;
   // Compute start indices to parameters and locals, and the number of
   // parameters to copy.
   if (num_opt_params == 0) {
-    // Parameter i will be at fp[1 + num_params - i] and local variable
-    // j will be at fp[kFirstLocalSlotIndex - j].
+    // Parameter i will be at fp[kLastParamSlotIndex + num_params - 1 - i] and
+    // local variable j will be at fp[kFirstLocalSlotIndex - j].
     ASSERT(GetSavedArgumentsDescriptorVar() == NULL);
-    first_parameter_index_ = 1 + num_params;
+    first_parameter_index_ = kLastParamSlotIndex + num_params - 1;

[zra, 2013/03/14 21:14:20]

It's a little surprising that the parser has to know something about the stack
layout.

[regis, 2013/03/14 21:32:22]

Yes, indeed. Allocating variables was moved out of the old code generator when
the new optimizing code generator was written. This allocation is actually
fairly high level. We just assign a slot index to parameters and locals. It does
not prevent locals to be ultimately allocated in registers, for example. The
index reflects more the position of parameters and position of local variables
in their respective scopes (or contexts, if captured) than their actual memory
address or register.  

     first_stack_local_index_ = kFirstLocalSlotIndex;
     num_copied_params_ = 0;
   } else {
     // Parameter i will be at fp[kFirstLocalSlotIndex - i] and local variable
     // j will be at fp[kFirstLocalSlotIndex - num_params - j].
     // The saved arguments descriptor variable must be allocated similarly to
     // a parameter, so that it gets both a frame slot and a context slot when
     // captured.
     if (GetSavedArgumentsDescriptorVar() != NULL) {
       num_params += 1;
@@ skipping 9894 matching lines @@
 void Parser::SkipQualIdent() {
   ASSERT(IsIdentifier());
   ConsumeToken();
   if (CurrentToken() == Token::kPERIOD) {
     ConsumeToken();  // Consume the kPERIOD token.
     ExpectIdentifier("identifier expected after '.'");
   }
 }
 
 }  // namespace dart