Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: tools/testing/dart/test_options.dart

Issue 12776004: Add support for the new analyzer to the testing scripts (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_options.dart
===================================================================
--- tools/testing/dart/test_options.dart (revision 19852)
+++ tools/testing/dart/test_options.dart (working copy)
@@ -77,9 +77,12 @@
safari, ie9, ie10, firefox, opera, none (compile only)),
dartc: Perform static analysis on Dart code by running dartc.
+ (only valid with the following runtimes: none),
+
+ new_analyzer: Perform static analysis on Dart code by running the analyzer.
(only valid with the following runtimes: none)''',
['-c', '--compiler'],
- ['none', 'dart2dart', 'dart2js', 'dartc'],
+ ['none', 'dart2dart', 'dart2js', 'dartc', 'new_analyzer'],
'none'),
new _TestOptionSpecification(
'runtime',
@@ -432,6 +435,7 @@
'opera'];
break;
case 'dartc':
+ case 'new_analyzer':
validRuntimes = const ['none'];
break;
case 'none':
@@ -508,8 +512,13 @@
configuration['runtime'] == 'ff';
}
+ String compiler = configuration['compiler'];
configuration['browser'] = TestUtils.isBrowserRuntime(runtime);
-
+ configuration['analyzer'] = TestUtils.isCommandLineAnalyzer(compiler);
+
+ print("analyzer");
+ print(compiler);
+ print(configuration['analyzer']);
kustermann 2013/03/12 17:55:23 Left over 'print'!
ricow1 2013/03/12 18:06:06 Done.
// Set the javascript command line flag for less verbose status files.
configuration['jscl'] = TestUtils.isJsCommandLineRuntime(runtime);
@@ -577,6 +586,7 @@
var timeout = 60;
switch (configuration['compiler']) {
case 'dartc':
+ case 'new_analyzer':
timeout *= 4;
break;
case 'dart2js':

Powered by Google App Engine
This is Rietveld 408576698