Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1277563002: Cherry-pick: Deny the geolocation permission request by default. (Closed)

Created:
5 years, 4 months ago by michaelbai
Modified:
5 years, 4 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2454
Target Ref:
refs/pending/branch-heads/2454
Project:
chromium
Visibility:
Public.

Description

Cherry-pick: Deny the geolocation permission request by default. This patch denies the request if there is no response when GeolocationPermission.Callback object is gc-ed. TBR=boliu BUG=513752 NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1267103003 Cr-Commit-Position: refs/heads/master@{#341760} (cherry picked from commit 97d22bb63d36d4d3049ef8f4009503acefb72bc9)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -47 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 3 chunks +8 lines, -20 lines 0 comments Download
A android_webview/java/src/org/chromium/android_webview/permission/AwGeolocationCallback.java View 1 chunk +76 lines, -0 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java View 9 chunks +59 lines, -20 lines 0 comments Download
M android_webview/native/aw_contents.cc View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277563002/1
5 years, 4 months ago (2015-08-05 18:23:23 UTC) #2
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
5 years, 4 months ago (2015-08-05 18:23:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277563002/1
5 years, 4 months ago (2015-08-05 18:35:21 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 18:37:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698