Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 1277543006: [d8 Workers] Make Worker prototype read-only (Closed)

Created:
5 years, 4 months ago by binji
Modified:
5 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[d8 Workers] Make Worker prototype read-only BUG=chromium:518747 R=mstarzinger@chromium.org LOG=n Committed: https://crrev.com/cd9293445e69c51846795fe9f526e970585a1423 Cr-Commit-Position: refs/heads/master@{#30099}

Patch Set 1 #

Patch Set 2 : add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/d8.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-518747.js View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
binji
5 years, 4 months ago (2015-08-10 19:24:49 UTC) #1
Michael Starzinger
LGTM. Should we add a regression test?
5 years, 4 months ago (2015-08-10 21:57:37 UTC) #2
binji
On 2015/08/10 at 21:57:37, mstarzinger wrote: > LGTM. Should we add a regression test? Whoops, ...
5 years, 4 months ago (2015-08-10 22:05:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277543006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277543006/20001
5 years, 4 months ago (2015-08-11 00:15:09 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-11 00:17:05 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 00:17:20 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cd9293445e69c51846795fe9f526e970585a1423
Cr-Commit-Position: refs/heads/master@{#30099}

Powered by Google App Engine
This is Rietveld 408576698