Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 1277523002: 10.10 SDK compatibility for Mac OS X 10.6 (Closed)

Created:
5 years, 4 months ago by Mark Mentovai
Modified:
5 years, 4 months ago
Reviewers:
Robert Sesek, erikchen
CC:
crashpad-dev_chromium.org, erikchen
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

10.10 SDK compatibility for Mac OS X 10.6. Both an SDK check and a runtime OS version check need to guard the use of task_dyld_info_data_t::all_image_info_format. The SDK check, which was already present, ensures that the field and macro constants are present in the SDK. The runtime check is also necessary. This bug was exposed in a 10.10 SDK and 10.6 deployment target build. TEST=crashpad_snapshot_test ProcessTypes.DyldImagesSelf BUG=chromium:463170 R=erikchen@chromium.org, rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/a3e313ecd72571d12965a51f9bad40b70b967cbc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M snapshot/mac/process_types_test.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mark Mentovai
5 years, 4 months ago (2015-08-05 18:06:52 UTC) #2
erikchen
lgtm
5 years, 4 months ago (2015-08-05 18:10:01 UTC) #4
Robert Sesek
LGTM
5 years, 4 months ago (2015-08-05 19:27:14 UTC) #5
Mark Mentovai
5 years, 4 months ago (2015-08-05 19:58:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a3e313ecd72571d12965a51f9bad40b70b967cbc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698