Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 1277503005: Fixed variable shadowing in BackgroundTracingManagerImpl::IsSupportedConfig (Closed)

Created:
5 years, 4 months ago by oystein (OOO til 10th of July)
Modified:
5 years, 4 months ago
Reviewers:
dsinclair
CC:
chromium-reviews, tracing+reviews_chromium.org, darin-cc_chromium.org, jam, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed variable shadowing in BackgroundTracingManagerImpl::IsSupportedConfig R=dsinclair Committed: https://crrev.com/8410ceed29253a91a1a70ab78d33b2f2d41048a1 Cr-Commit-Position: refs/heads/master@{#341964}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M content/browser/tracing/background_tracing_manager_impl.cc View 2 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
oystein (OOO til 10th of July)
5 years, 4 months ago (2015-08-05 18:13:28 UTC) #1
dsinclair
lgtm please remove the BUG= link if not needed.
5 years, 4 months ago (2015-08-05 18:15:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277503005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277503005/1
5 years, 4 months ago (2015-08-05 18:21:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-05 20:37:21 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 20:38:38 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8410ceed29253a91a1a70ab78d33b2f2d41048a1
Cr-Commit-Position: refs/heads/master@{#341964}

Powered by Google App Engine
This is Rietveld 408576698