Fix LatencyInfo compile error for ipc fuzzer

Fix LatencyInfo compile error for ipc fuzzer

BUG=516927
TBR=inferno@chromium.org

Committed: https://crrev.com/dad5f3d8a876981d8a053bd2f81b13e2b69bb1a6
Cr-Commit-Position: refs/heads/master@{#341950}

[Yufeng Shen (Slow to review), 2015-08-05 15:09:35]

The CQ bit was checked by miletus@chromium.org

[commit-bot: I haz the power, 2015-08-05 15:10:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1277483002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1277483002/1

[inferno, 2015-08-05 15:14:20]

The CQ bit was unchecked by inferno@chromium.org

[inferno, 2015-08-05 15:16:09]

inferno@chromium.org changed reviewers:
+ mbarbella@chromium.org, tsepez@google.com

[inferno, 2015-08-05 15:16:10]

https://codereview.chromium.org/1277483002/diff/1/tools/ipc_fuzzer/fuzzer/fuz...
File tools/ipc_fuzzer/fuzzer/fuzzer.cc (right):

https://codereview.chromium.org/1277483002/diff/1/tools/ipc_fuzzer/fuzzer/fuz...
tools/ipc_fuzzer/fuzzer/fuzzer.cc:1778: if (!FuzzParam(&terminated, fuzzer))
Removing the cq since there is a part missing. If you use local vars, you need
to recreate p with the the fuzzed data. See FuzzTraits<url::Origin> for example.

[Yufeng Shen (Slow to review), 2015-08-05 15:31:15]

On 2015/08/05 15:16:10, inferno wrote:
>
https://codereview.chromium.org/1277483002/diff/1/tools/ipc_fuzzer/fuzzer/fuz...
> File tools/ipc_fuzzer/fuzzer/fuzzer.cc (right):
> 
>
https://codereview.chromium.org/1277483002/diff/1/tools/ipc_fuzzer/fuzzer/fuz...
> tools/ipc_fuzzer/fuzzer/fuzzer.cc:1778: if (!FuzzParam(&terminated, fuzzer))
> Removing the cq since there is a part missing. If you use local vars, you need
> to recreate p with the the fuzzed data. See FuzzTraits<url::Origin> for
example.

ah, missed that. PTAL, thanks.

[inferno, 2015-08-05 15:40:02]

https://codereview.chromium.org/1277483002/diff/20001/tools/ipc_fuzzer/fuzzer...
File tools/ipc_fuzzer/fuzzer/fuzzer.cc (right):

https://codereview.chromium.org/1277483002/diff/20001/tools/ipc_fuzzer/fuzzer...
tools/ipc_fuzzer/fuzzer/fuzzer.cc:1776: return true;
Can't we just call a ui::LatencyInfo constructor that construct using the local
vars you created in the last patch. then we won't this friend class hack.

https://codereview.chromium.org/1277483002/diff/20001/ui/events/latency_info.h
File ui/events/latency_info.h (right):

https://codereview.chromium.org/1277483002/diff/20001/ui/events/latency_info....
ui/events/latency_info.h:21: namespace ipc_fuzzer {
We never sprinkle ipc fuzzer code in regular builds, so please remove changes in
this file.

[Yufeng Shen (Slow to review), 2015-08-05 16:08:24]

https://codereview.chromium.org/1277483002/diff/20001/tools/ipc_fuzzer/fuzzer...
File tools/ipc_fuzzer/fuzzer/fuzzer.cc (right):

https://codereview.chromium.org/1277483002/diff/20001/tools/ipc_fuzzer/fuzzer...
tools/ipc_fuzzer/fuzzer/fuzzer.cc:1776: return true;
On 2015/08/05 15:40:01, inferno wrote:
> Can't we just call a ui::LatencyInfo constructor that construct using the
local
> vars you created in the last patch. then we won't this friend class hack.

LatencyInfo is not supposed to be constructed with those values passed in
actually. But anyway, I wrote a test-only constructor
for this purpose.

https://codereview.chromium.org/1277483002/diff/20001/ui/events/latency_info.h
File ui/events/latency_info.h (right):

https://codereview.chromium.org/1277483002/diff/20001/ui/events/latency_info....
ui/events/latency_info.h:21: namespace ipc_fuzzer {
On 2015/08/05 15:40:01, inferno wrote:
> We never sprinkle ipc fuzzer code in regular builds, so please remove changes
in
> this file.

I copied from here 
https://code.google.com/p/chromium/codesearch#search/&q=%22friend%20struct%20...

guess it is better to clean those up ?

[inferno, 2015-08-05 16:14:26]

lgtm.

Tom is cced, who can look into why those cases were left.

[inferno, 2015-08-05 16:14:39]

inferno@chromium.org changed reviewers:
+ tsepez@chromium.org
- tsepez@google.com

[inferno, 2015-08-05 16:14:44]

The CQ bit was checked by inferno@chromium.org

[commit-bot: I haz the power, 2015-08-05 16:15:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1277483002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1277483002/40001

[Tom Sepez, 2015-08-05 16:46:14]

lgtm

[commit-bot: I haz the power, 2015-08-05 18:13:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-05 18:13:44]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Yufeng Shen (Slow to review), 2015-08-05 18:39:36]

The CQ bit was checked by miletus@chromium.org

[commit-bot: I haz the power, 2015-08-05 18:40:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1277483002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1277483002/40001

[commit-bot: I haz the power, 2015-08-05 20:07:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-05 20:08:08]

Patchset 3 (id:??) landed as
https://crrev.com/dad5f3d8a876981d8a053bd2f81b13e2b69bb1a6
Cr-Commit-Position: refs/heads/master@{#341950}