Fix for Crashing IOS Stroke test

This is a speculative fix for the crash on IOS
TBR=mtklein

Committed: https://skia.googlesource.com/skia/+/9d144ac15f26c0148dbcb82dd5aa1a348cb912ee

[egdaniel, 2015-08-10 14:45:03]

Patchset #3 (id:30001) has been deleted

[egdaniel, 2015-08-10 14:50:52]

egdaniel@google.com changed reviewers:
+ mtklein@google.com, senorblanco@google.com

[egdaniel, 2015-08-10 14:50:53]

Okay so this seems to fix the IOS crash. Basically it goes back to the "leak"
version and adds a delete at the end (see patch 1 for trybot).

However, just to be even more confused look at patch set 2 which also passed.
How that works and the current world fails I have no idea!!

Mtklein: I just grabbed your latest patch set from your testing cl. Is there
value to the change in CommonFlags or was that purely for debugging?

[Stephen White, 2015-08-10 14:56:43]

At this point, I'm thinking this is a compiler bug. Might be interesting to look
at the assembly, if someone has the time and inclination.

[mtklein, 2015-08-10 15:23:50]

On 2015/08/10 14:56:43, Stephen White wrote:
> At this point, I'm thinking this is a compiler bug. Might be interesting to
look
> at the assembly, if someone has the time and inclination.

Agreed.  I have time but no inclination.  Happy to fire this and forget.

[mtklein, 2015-08-10 15:23:56]

https://codereview.chromium.org/1277433005/diff/50001/tools/flags/SkCommonFla...
File tools/flags/SkCommonFlags.cpp (right):

https://codereview.chromium.org/1277433005/diff/50001/tools/flags/SkCommonFla...
tools/flags/SkCommonFlags.cpp:29: DEFINE_string2(match, m, "GLPrograms",
Revert this file?

[egdaniel, 2015-08-10 16:57:23]

Patchset #4 (id:70001) has been deleted

[egdaniel, 2015-08-10 16:59:13]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2015-08-10 16:59:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1277433005/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1277433005/90001

[mtklein, 2015-08-10 17:01:21]

lgtm

[commit-bot: I haz the power, 2015-08-10 17:06:49]

Committed patchset #4 (id:90001) as
https://skia.googlesource.com/skia/+/9d144ac15f26c0148dbcb82dd5aa1a348cb912ee