Increase kShutdownDetectorThreadStackSize to avoid tcmalloc stack overflow.

Increase kShutdownDetectorThreadStackSize to avoid tcmalloc stack overflow.

BUG=332297
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243702

[jochen (gone - plz use gerrit), 2014-01-08 09:56:10]

lgtm

[commit-bot: I haz the power, 2014-01-08 10:15:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mattm@chromium.org/127743002/1

[commit-bot: I haz the power, 2014-01-08 16:29:56]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[michaelbai, 2014-01-08 16:50:22]

Is there way to check the stack is overflow?

[mattm, 2014-01-08 20:58:34]

On 2014/01/08 16:50:22, michaelbai wrote:
> Is there way to check the stack is overflow?

In gdb, when you have a segfault, you can do "p
$_siginfo._sifields._sigfault.si_addr" to print the address of the segfault, and
"info registers" to print the registers, and then compare the segfault address
with the stack pointer.

Ex: 
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffd8d67700 (LWP 28956)]
...
(gdb) p $_siginfo._sifields._sigfault.si_addr
$1 = (void *) 0x7fffd8d64fd8
(gdb) info registers
...
rsp            0x7fffd8d65190   0x7fffd8d65190
...

You can see the segfault happened right after the current stack pointer.

[commit-bot: I haz the power, 2014-01-08 21:01:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mattm@chromium.org/127743002/1

[michaelbai, 2014-01-08 21:31:25]

On 2014/01/08 20:58:34, mattm wrote:
> On 2014/01/08 16:50:22, michaelbai wrote:
> > Is there way to check the stack is overflow?
> 
> In gdb, when you have a segfault, you can do "p
> $_siginfo._sifields._sigfault.si_addr" to print the address of the segfault,
and
> "info registers" to print the registers, and then compare the segfault address
> with the stack pointer.
> 
> Ex: 
> Program received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 0x7fffd8d67700 (LWP 28956)]
> ...
> (gdb) p $_siginfo._sifields._sigfault.si_addr
> $1 = (void *) 0x7fffd8d64fd8
> (gdb) info registers
> ...
> rsp            0x7fffd8d65190   0x7fffd8d65190
> ...
> 
> You can see the segfault happened right after the current stack pointer.

Thanks for the information, actually I were thinking is there a way to detect
stack overflow in the code, so the next time, people don't need to debug around
to fix this issue.

[commit-bot: I haz the power, 2014-01-09 00:01:49]

Change committed as 243702