src/runtime/runtime-i18n.cc - Issue 1277353002: Use static_cast<> for NULL (clang 3.7)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-i18n.cc

Issue 1277353002: Use static_cast<> for NULL (clang 3.7) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Use nullptr everywhere, squash commits Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-i18n.cc

diff --git a/src/runtime/runtime-i18n.cc b/src/runtime/runtime-i18n.cc

index 18e9aee126b47329cfd847d08ff88dde0aa101e4..3da71a98ef309d23b7d31f0349a751536602a728 100644

--- a/src/runtime/runtime-i18n.cc

+++ b/src/runtime/runtime-i18n.cc

@@ -626,7 +626,7 @@ RUNTIME_FUNCTION(Runtime_CreateBreakIterator) {

local_object->SetInternalField(0, reinterpret_cast<Smi*>(break_iterator));

// Make sure that the pointer to adopted text is NULL.

- local_object->SetInternalField(1, reinterpret_cast<Smi*>(NULL));

+ local_object->SetInternalField(1, static_cast<Smi*>(nullptr));

Factory* factory = isolate->factory();

Handle<String> key = factory->NewStringFromStaticChars("breakIterator");

« no previous file with comments | « AUTHORS ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »