Chromium Code Reviews Chromium Code Reviews
Issue
1277273002:
Revert of Upon load failure, remove sync script from execution queue. (Closed)
DescriptionRevert of Upon load failure, remove sync script from execution queue. (patchset #4 id:60001 of https://codereview.chromium.org/1263743002/ )
Reason for revert:
Crashes due to a release assert added here are being reported in https://code.google.com/p/chromium/issues/detail?id=517970 . Better revert this until that can be looked into more closely.
Original issue's description:
> Upon load failure, remove sync script from execution queue.
>
> If a script element is to be loaded synchronously and executed in order,
> it's queued for execution before loading. Should that load fail, the
> immediate execution of the script,
>
> https://html.spec.whatwg.org/#execute-the-script-block
>
> should only result in an error event being dispatched.
>
> Implementation-wise, along with signalling error, the failed script must also
> be removed from the internal in-order execution queue. We're done with
> (not) executing the script and failure to remove it will cause subsequent
> processing of the script execution queue to see the script as having failed
> to load and re-dispatch an error event.
>
> [This is a reland of r199656, which wrongly updated&removed scripts from the
> in-order queue.]
>
> R=haraken
> BUG=503077
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200045
TBR=haraken@chromium.org,tkent@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=503077
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200186
Patch Set 1 #
Created: 5 years, 4 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
