Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1277253002: Apply the bot config api based on the command line arguments. (Closed)

Created:
5 years, 4 months ago by Geoff Lang
Modified:
5 years, 3 months ago
Reviewers:
Zhenyao Mo, no sievers
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply the bot config api based on the command line arguments. Allows for expectations based on the ANGLE renderer. BUG=490149 Committed: https://crrev.com/68c9284f34a247d12327d188d75b81b1b4dd3791 Cr-Commit-Position: refs/heads/master@{#345331} Committed: https://crrev.com/48b4fba870ec20212e451e95a841cab89e6ea121 Cr-Commit-Position: refs/heads/master@{#345369}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Fix compile failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -6 lines) Patch
M gpu/gles2_conform_support/gles2_conform_test.cc View 1 2 2 chunks +35 lines, -6 lines 0 comments Download
M gpu/gles2_conform_support/gles2_conform_test_expectations.txt View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (7 generated)
Geoff Lang
PTAL
5 years, 4 months ago (2015-08-07 19:14:55 UTC) #2
Geoff Lang
friendly review ping.
5 years, 4 months ago (2015-08-18 13:24:44 UTC) #3
Zhenyao Mo
LGTM with one var name fixed https://codereview.chromium.org/1277253002/diff/1/gpu/gles2_conform_support/gles2_conform_test.cc File gpu/gles2_conform_support/gles2_conform_test.cc (right): https://codereview.chromium.org/1277253002/diff/1/gpu/gles2_conform_support/gles2_conform_test.cc#newcode49 gpu/gles2_conform_support/gles2_conform_test.cc:49: base::CommandLine* currentCmdLine = ...
5 years, 4 months ago (2015-08-18 13:36:01 UTC) #4
Geoff Lang
sievers: Need you to do an owners review when you can, please. https://codereview.chromium.org/1277253002/diff/1/gpu/gles2_conform_support/gles2_conform_test.cc File gpu/gles2_conform_support/gles2_conform_test.cc ...
5 years, 4 months ago (2015-08-18 14:06:10 UTC) #5
no sievers
lgtm
5 years, 4 months ago (2015-08-18 19:14:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277253002/20001
5 years, 4 months ago (2015-08-18 19:16:18 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/41101)
5 years, 4 months ago (2015-08-18 20:36:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277253002/20001
5 years, 3 months ago (2015-08-25 13:55:14 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-25 15:32:21 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/68c9284f34a247d12327d188d75b81b1b4dd3791 Cr-Commit-Position: refs/heads/master@{#345331}
5 years, 3 months ago (2015-08-25 15:33:29 UTC) #15
Geoff Lang
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1308073004/ by geofflang@chromium.org. ...
5 years, 3 months ago (2015-08-25 15:43:03 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277253002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277253002/40001
5 years, 3 months ago (2015-08-25 16:37:09 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-08-25 17:42:05 UTC) #20
commit-bot: I haz the power
5 years, 3 months ago (2015-08-25 17:42:51 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/48b4fba870ec20212e451e95a841cab89e6ea121
Cr-Commit-Position: refs/heads/master@{#345369}

Powered by Google App Engine
This is Rietveld 408576698