Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1277243002: Copy only the DLLs for the default toolchain on Windows. (Closed)

Created:
5 years, 4 months ago by brettw
Modified:
5 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Copy only the DLLs for the default toolchain on Windows. Previuosly this would copy them 4 times, once for each Windows toolchain: 32-bit, 64-bit clang-32-bit and clang-64-bit. This should only actually be needed for the default toolchain. This speeds up running GN on Windows by ~1/2 second on average. Committed: https://crrev.com/874ab4a07af724464c8e8d7375b807b03e6ef68c Cr-Commit-Position: refs/heads/master@{#342419}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -13 lines) Patch
M build/toolchain/win/BUILD.gn View 2 chunks +17 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
brettw
5 years, 4 months ago (2015-08-07 19:11:22 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277243002/1
5 years, 4 months ago (2015-08-07 19:12:15 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-07 19:44:02 UTC) #6
brettw
-> jam, apparently sky is OOO
5 years, 4 months ago (2015-08-07 19:51:48 UTC) #8
jam
lgtm
5 years, 4 months ago (2015-08-07 19:52:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277243002/1
5 years, 4 months ago (2015-08-07 19:52:58 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 19:58:12 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 19:58:55 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/874ab4a07af724464c8e8d7375b807b03e6ef68c
Cr-Commit-Position: refs/heads/master@{#342419}

Powered by Google App Engine
This is Rietveld 408576698