Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: Source/bindings/tests/results/V8TestObject.cpp

Issue 127723002: Add use counters for using Attrs as Nodes. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Bring patch to head. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestObject.cpp
diff --git a/Source/bindings/tests/results/V8TestObject.cpp b/Source/bindings/tests/results/V8TestObject.cpp
index 0dbd87b867977f85413cfe24937943649ed2b873..747d9612ac43351968e317d5fce17b9cc75a9ee9 100644
--- a/Source/bindings/tests/results/V8TestObject.cpp
+++ b/Source/bindings/tests/results/V8TestObject.cpp
@@ -35,6 +35,7 @@
#include "HTMLNames.h"
#include "RuntimeEnabledFeatures.h"
+#include "V8Attr.h"
#include "V8DOMStringList.h"
#include "V8Document.h"
#include "V8MessagePort.h"
@@ -5061,6 +5062,10 @@ static void variadicNodeMethodMethod(const v8::FunctionCallbackInfo<v8::Value>&
static void variadicNodeMethodMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
{
TRACE_EVENT_SET_SAMPLING_STATE("Blink", "DOMMethod");
+ if (V8DOMWrapper::isWrapperOfType(info[0], &V8Attr::wrapperTypeInfo))
+ UseCounter::count(activeExecutionContext(), UseCounter::AttrUsedAsNodeParameter);
+ if (V8DOMWrapper::isWrapperOfType(info[1], &V8Attr::wrapperTypeInfo))
+ UseCounter::count(activeExecutionContext(), UseCounter::AttrUsedAsNodeParameter);
TestObjV8Internal::variadicNodeMethodMethod(info);
TRACE_EVENT_SET_SAMPLING_STATE("V8", "V8Execution");
}
« no previous file with comments | « Source/bindings/tests/results/V8TestInterface.cpp ('k') | Source/bindings/tests/results/V8TestObjectPython.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698