Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: components/error_page/common/net_error_info.h

Issue 1277213003: Move DNS functions from net_error_info.h into error_page namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/net/net_error_helper.cc ('k') | components/error_page/common/net_error_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/error_page/common/net_error_info.h
diff --git a/components/error_page/common/net_error_info.h b/components/error_page/common/net_error_info.h
index f67c9b0c2f00da4ab66ab82adda7f3c83114f2f8..4ebd0688953cbfa1cff317b2ca80eb5682246101 100644
--- a/components/error_page/common/net_error_info.h
+++ b/components/error_page/common/net_error_info.h
@@ -83,6 +83,10 @@ enum DnsProbeStatus {
DNS_PROBE_MAX
};
+} // namespace chrome_common_net
+
+namespace error_page {
+
// Returns a string representing |status|. It should be simply the name of
// the value as a string, but don't rely on that. This is presented to the
// user as part of the DNS error page (as the error code, at the bottom),
@@ -94,15 +98,15 @@ enum DnsProbeStatus {
const char* DnsProbeStatusToString(int status);
// Returns true if |status| is one of the DNS_PROBE_FINISHED_* statuses.
-bool DnsProbeStatusIsFinished(DnsProbeStatus status);
+bool DnsProbeStatusIsFinished(chrome_common_net::DnsProbeStatus status);
// Record specific error page events.
-void RecordEvent(NetworkErrorPageEvent event);
+void RecordEvent(chrome_common_net::NetworkErrorPageEvent event);
// The error domain used to pass DNS probe statuses to the localized error
// code.
extern const char kDnsProbeErrorDomain[];
-} // namespace chrome_common_net
+} // namespace error_page
#endif // COMPONENTS_ERROR_PAGE_COMMON_NET_ERROR_INFO_H_
« no previous file with comments | « chrome/renderer/net/net_error_helper.cc ('k') | components/error_page/common/net_error_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698