Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: components/error_page/common/net_error_info.cc

Issue 1277213003: Move DNS functions from net_error_info.h into error_page namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/error_page/common/net_error_info.cc
diff --git a/components/error_page/common/net_error_info.cc b/components/error_page/common/net_error_info.cc
index 7483e737983a391c4230fbd53f865cbdcc3f4126..0fd913bd119197cc0df50276a1e42eaae0f13ffe 100644
--- a/components/error_page/common/net_error_info.cc
+++ b/components/error_page/common/net_error_info.cc
@@ -7,40 +7,40 @@
#include "base/logging.h"
#include "base/metrics/histogram_macros.h"
-namespace chrome_common_net {
+namespace error_page {
const char kDnsProbeErrorDomain[] = "dnsprobe";
const char* DnsProbeStatusToString(int status) {
switch (status) {
- case DNS_PROBE_POSSIBLE:
- return "DNS_PROBE_POSSIBLE";
- case DNS_PROBE_NOT_RUN:
- return "DNS_PROBE_NOT_RUN";
- case DNS_PROBE_STARTED:
- return "DNS_PROBE_STARTED";
- case DNS_PROBE_FINISHED_INCONCLUSIVE:
- return "DNS_PROBE_FINISHED_INCONCLUSIVE";
- case DNS_PROBE_FINISHED_NO_INTERNET:
- return "DNS_PROBE_FINISHED_NO_INTERNET";
- case DNS_PROBE_FINISHED_BAD_CONFIG:
- return "DNS_PROBE_FINISHED_BAD_CONFIG";
- case DNS_PROBE_FINISHED_NXDOMAIN:
- return "DNS_PROBE_FINISHED_NXDOMAIN";
- default:
- NOTREACHED();
- return "";
+ case chrome_common_net::DNS_PROBE_POSSIBLE:
+ return "DNS_PROBE_POSSIBLE";
+ case chrome_common_net::DNS_PROBE_NOT_RUN:
+ return "DNS_PROBE_NOT_RUN";
+ case chrome_common_net::DNS_PROBE_STARTED:
+ return "DNS_PROBE_STARTED";
+ case chrome_common_net::DNS_PROBE_FINISHED_INCONCLUSIVE:
+ return "DNS_PROBE_FINISHED_INCONCLUSIVE";
+ case chrome_common_net::DNS_PROBE_FINISHED_NO_INTERNET:
+ return "DNS_PROBE_FINISHED_NO_INTERNET";
+ case chrome_common_net::DNS_PROBE_FINISHED_BAD_CONFIG:
+ return "DNS_PROBE_FINISHED_BAD_CONFIG";
+ case chrome_common_net::DNS_PROBE_FINISHED_NXDOMAIN:
+ return "DNS_PROBE_FINISHED_NXDOMAIN";
+ default:
+ NOTREACHED();
+ return "";
}
}
-bool DnsProbeStatusIsFinished(DnsProbeStatus status) {
- return status >= DNS_PROBE_FINISHED_INCONCLUSIVE &&
- status < DNS_PROBE_MAX;
+bool DnsProbeStatusIsFinished(chrome_common_net::DnsProbeStatus status) {
+ return status >= chrome_common_net::DNS_PROBE_FINISHED_INCONCLUSIVE &&
+ status < chrome_common_net::DNS_PROBE_MAX;
}
-void RecordEvent(NetworkErrorPageEvent event) {
+void RecordEvent(chrome_common_net::NetworkErrorPageEvent event) {
UMA_HISTOGRAM_ENUMERATION("Net.ErrorPageCounts", event,
- NETWORK_ERROR_PAGE_EVENT_MAX);
+ chrome_common_net::NETWORK_ERROR_PAGE_EVENT_MAX);
}
-} // namespace chrome_common_net
+} // namespace error_page
« no previous file with comments | « components/error_page/common/net_error_info.h ('k') | components/error_page/renderer/net_error_helper_core.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698