Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 1277213003: Move DNS functions from net_error_info.h into error_page namespace. (Closed)

Created:
5 years, 4 months ago by tfarina
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, hashimoto
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move DNS functions from net_error_info.h into error_page namespace. This was a TODO for hashimoto. The rest of the file will be moved into error_page in a separate CL. BUG=None R=mmenke@chromium.org,thestig@chromium.org Committed: https://crrev.com/01832b64148786bb4fc69458693d1e7111a112ef Cr-Commit-Position: refs/heads/master@{#342699}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -72 lines) Patch
M chrome/browser/net/dns_probe_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/net_error_tab_helper.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/localized_error.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/net/net_error_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/error_page/common/net_error_info.h View 2 chunks +7 lines, -3 lines 0 comments Download
M components/error_page/common/net_error_info.cc View 1 chunk +24 lines, -24 lines 0 comments Download
M components/error_page/renderer/net_error_helper_core.cc View 5 chunks +19 lines, -29 lines 0 comments Download
M components/error_page/renderer/net_error_helper_core_unittest.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tfarina
Lei -> chrome Matt -> error_page PTAL https://codereview.chromium.org/1277213003/diff/1/components/error_page/common/net_error_info.h File components/error_page/common/net_error_info.h (right): https://codereview.chromium.org/1277213003/diff/1/components/error_page/common/net_error_info.h#newcode12 components/error_page/common/net_error_info.h:12: enum NetworkErrorPageEvent ...
5 years, 4 months ago (2015-08-10 18:19:00 UTC) #1
mmenke
On 2015/08/10 18:19:00, tfarina wrote: > Lei -> chrome > Matt -> error_page > > ...
5 years, 4 months ago (2015-08-10 18:25:40 UTC) #2
Lei Zhang
lgtm
5 years, 4 months ago (2015-08-10 18:40:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277213003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277213003/20001
5 years, 4 months ago (2015-08-10 21:14:47 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-10 21:20:20 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 21:21:13 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/01832b64148786bb4fc69458693d1e7111a112ef
Cr-Commit-Position: refs/heads/master@{#342699}

Powered by Google App Engine
This is Rietveld 408576698