src/codec/SkBmpCodec.cpp - Issue 1277213002: Support more swizzles to 565 in SkCodec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkBmpCodec.cpp

Issue 1277213002: Support more swizzles to 565 in SkCodec (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Update new 565 swizzling functions for scaling Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkBmpCodec.cpp

diff --git a/src/codec/SkBmpCodec.cpp b/src/codec/SkBmpCodec.cpp

index fa4608ffeec513cacd753fc3efc721497d1eff3c..20af2da06fe0db122b86b49bef63b5c7ba6da8bc 100644

--- a/src/codec/SkBmpCodec.cpp

+++ b/src/codec/SkBmpCodec.cpp

@@ -397,6 +397,7 @@ bool SkBmpCodec::ReadHeader(SkStream* stream, bool inIco, SkCodec** codecOut) {

iBuffer.free();

// Additionally, 32 bit bmp-in-icos use the alpha channel.

+ // FIXME (msarett): Don't all bmp-in-icos use the alpha channel?

// And, RLE inputs may skip pixels, leaving them as transparent. This

// is uncommon, but we cannot be certain that an RLE bmp will be opaque.

if ((inIco && 32 == bitsPerPixel) || (kRLE_BmpInputFormat == inputFormat)) {