Support more swizzles to 565 in SkCodec

src/codec/SkCodecPriv.h

 /*
  * Copyright 2015 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkCodecPriv_DEFINED
 #define SkCodecPriv_DEFINED
 
@@ skipping 35 matching lines @@
                 break;
             default:
                 // We cannot decode a non-opaque image to opaque (or unknown)
                 return false;
         }
     }
     return true;
 }
 
 /*
+ * Most of our codecs support the same conversions:
+ * - profileType must be the same
+ * - opaque only to opaque (and 565 only if opaque)
+ * - premul to unpremul and vice versa
+ * - always support N32
+ * - otherwise match the src color type
+ */
+static bool conversion_possible(const SkImageInfo& dst, const SkImageInfo& src) {

[scroggo_chromium, 2015/08/10 17:26:16]

This function is a simplified version of the method that showed up in other
files.

[msarett, 2015/08/10 17:44:24]

Nice!  This is a big improvement.

+    if (dst.profileType() != src.profileType()) {
+        return false;
+    }
+
+    // Ensure the alpha type is valid
+    if (!valid_alpha(dst.alphaType(), src.alphaType())) {
+        return false;
+    }
+
+    // Check for supported color types
+    switch (dst.colorType()) {
+        case kN32_SkColorType:
+            return true;
+        case kRGB_565_SkColorType:

[scroggo_chromium, 2015/08/10 17:26:16]

This part is different - I've added support for 565, if the source is opaque.

+            return src.alphaType() == kOpaque_SkAlphaType;
+        default:
+            return dst.colorType() == src.colorType();

[scroggo_chromium, 2015/08/10 17:26:16]

Some versions of conversion_possible checked specifically for index8. That is
covered by this check.

+    }
+}
+
+/*
  * If there is a color table, get a pointer to the colors, otherwise return NULL
  */
 static const SkPMColor* get_color_ptr(SkColorTable* colorTable) {
      return NULL != colorTable ? colorTable->readColors() : NULL;
 }
 
 /*
  *
  * Copy the codec color table back to the client when kIndex8 color type is requested
  */
@@ skipping 72 matching lines @@
 #endif
 }
 
 #ifdef SK_PRINT_CODEC_MESSAGES
     #define SkCodecPrintf SkDebugf
 #else
     #define SkCodecPrintf(...)
 #endif
 
 #endif // SkCodecPriv_DEFINED