Issue 12772003: Removed unused parameters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12772003: Removed unused parameters (Closed)

Created:
7 years, 9 months ago by sugoi1

Modified:
7 years, 9 months ago

Reviewers:
sugoi, Justin Novosad

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Removed unused parameters I removed unused parameters wherever it was trivial to do so. Committed: https://code.google.com/p/skia/source/detail?r=8103

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -47 lines)			Patch
M	samplecode/SampleCircle.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	samplecode/SampleEffects.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	samplecode/SampleLayers.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	samplecode/SampleRepeatTile.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/animator/SkAnimator.cpp	View	1 2 3 4	6 chunks	+9 lines, -7 lines	0 comments	Download
M	src/animator/SkDisplayMovie.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/animator/SkDrawBitmap.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/animator/SkDrawColor.cpp	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/animator/SkDrawExtraPathEffect.cpp	View	1 2 3	2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/animator/SkDrawGroup.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/animator/SkDump.cpp	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/animator/SkHitClear.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/animator/SkHitTest.cpp	View	1 2 3	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/animator/SkPaintParts.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkPtrRecorder.h	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/core/SkScan_Hairline.cpp	View	1 2 3	3 chunks	+2 lines, -11 lines	0 comments	Download
M	src/gpu/effects/GrEllipseEdgeEffect.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/views/SkViewPriv.cpp	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/views/SkWindow.cpp	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/views/unix/SkOSWindow_Unix.cpp	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sugoi1

7 years, 9 months ago (2013-03-12 14:37:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r8103 (presubmit successful).

Expand Messages | Collapse Messages