Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5410)

Unified Diff: chrome/browser/resources/chromeos/chromevox/generate_manifest.gypi

Issue 1277183003: Add ChromeVox panel and implement caption display functionality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Finish initial implementation for Chrome OS, address feedback Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/generate_manifest.gypi
diff --git a/chrome/browser/resources/chromeos/chromevox/generate_manifest.gypi b/chrome/browser/resources/chromeos/chromevox/generate_manifest.gypi
index 758a73e77efd9b6e0db8a86e145b72ac400cfe45..f7fd0bcabc62ce7653a9d18062095cab4c6c2358 100644
--- a/chrome/browser/resources/chromeos/chromevox/generate_manifest.gypi
+++ b/chrome/browser/resources/chromeos/chromevox/generate_manifest.gypi
@@ -22,6 +22,7 @@
'generate_manifest_script_path': 'tools/generate_manifest.py',
'is_guest_manifest%': 0,
'is_chromevox_classic%': 0,
+ 'is_chromeos%': 1,
Peter Lundblad 2015/11/06 15:00:58 We already have a variable in gyp called 'chromeos
dmazzoni 2015/11/06 21:01:01 I ended up getting rid of the accessibilityFeature
},
'includes': [
'../../../../../build/util/version.gypi',
@@ -42,6 +43,7 @@
'<(generate_manifest_script_path)',
'--is_guest_manifest=<(is_guest_manifest)',
'--key=<(chromevox_extension_key)',
+ '--is_chromeos=<(is_chromeos)',
'--is_chromevox_classic=<(is_chromevox_classic)',
'--is_js_compressed=<(chromevox_compress_js)',
'--set_version=<(version_full)',

Powered by Google App Engine
This is Rietveld 408576698