chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js - Issue 1277183003: Add ChromeVox panel and implement caption display functionality.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js

Issue 1277183003: Add ChromeVox panel and implement caption display functionality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finish initial implementation for Chrome OS, address feedback Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/BUILD.gn ('k') | chrome/browser/resources/chromeos/chromevox/chromevox.gni » ('j') | chrome/browser/resources/chromeos/chromevox/chromevox_assets.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js

diff --git a/chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js b/chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js

index 1f09ad4083ea7ecfad815a56ec2672f6ff838310..d2441e4a1eedbd2f755f04327c1b32c99693f1d9 100644

--- a/chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js

+++ b/chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js

@@ -195,11 +195,12 @@ cvox.BrailleDisplayManager.prototype.refresh_ = function() {

if (this.realDisplayState_.available) {

chrome.brailleDisplayPrivate.writeDots(buf);

}

+ var start = this.brailleToTextPosition_(viewPort.start);

+ var end = this.brailleToTextPosition_(viewPort.end);

+ var brailleText = this.content_.text.toString().substring(start, end);

if (cvox.BrailleCaptionsBackground.isEnabled()) {

- var start = this.brailleToTextPosition_(viewPort.start);

- var end = this.brailleToTextPosition_(viewPort.end);

- cvox.BrailleCaptionsBackground.setContent(

- this.content_.text.toString().substring(start, end), buf);

+ cvox.BrailleCaptionsBackground.setContent(brailleText, buf);

Peter Lundblad 2015/11/06 15:00:57 What's the point of this change?

dmazzoni 2015/11/06 21:01:00 Oops, I originally tried hooking into this file to

}

};