chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js - Issue 1277183003: Add ChromeVox panel and implement caption display functionality.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

Issue 1277183003: Add ChromeVox panel and implement caption display functionality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix GN build Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/chromevox_vars.gypi ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

index 424cfda10bcb01386fbbc7b38e31ab672dcf291b..8f812bb76bd2b2450057312fff239dde034fe11a 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

@@ -353,8 +353,7 @@ Background.prototype = {

}

break;

case 'showOptionsPage':

- var optionsPage = {url: 'chromevox/background/options.html'};

- chrome.tabs.create(optionsPage);

+ chrome.runtime.openOptionsPage();

break;

case 'toggleChromeVoxVersion':

var newMode;

@@ -412,6 +411,14 @@ Background.prototype = {

/**

+ * Open the options page in a new tab.

+ */

+ showOptionsPage: function() {

+ var optionsPage = {url: 'chromevox/background/options.html'};

+ chrome.tabs.create(optionsPage);

+ },

+ /**

* Handles a braille command.

* @param {!cvox.BrailleKeyEvent} evt

* @param {!cvox.NavBraille} content