Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1277183002: Fix running "gen gn --args='target_os="ios"'". (Closed)

Created:
5 years, 4 months ago by sherouk
Modified:
5 years, 4 months ago
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix running "gen gn --args='target_os="ios"'". //third_party/WebKit is not supported on iOS, so put the deps behind a is_ios check. BUG=None Committed: https://crrev.com/80095df2d3c7d86cd4a5775b91baa50c3a67375e Cr-Commit-Position: refs/heads/master@{#342356}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ui/resources/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sherouk
Please take a look.
5 years, 4 months ago (2015-08-07 14:39:54 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 4 months ago (2015-08-07 14:43:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277183002/1
5 years, 4 months ago (2015-08-07 14:50:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 15:15:54 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 15:16:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80095df2d3c7d86cd4a5775b91baa50c3a67375e
Cr-Commit-Position: refs/heads/master@{#342356}

Powered by Google App Engine
This is Rietveld 408576698