Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
12771026:
checklicenses: remove libwebp from path whitelist (Closed)
|
Created:
7 years, 9 months ago by jzern Modified:
7 years, 5 months ago CC:
chromium-reviews Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
Descriptionchecklicenses: remove libwebp from path whitelist
after libwebp-0.3.1 it's correctly detected as BSD-like.
R=thestig@chromium.org
BUG=98448
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209261
Patch Set 1 #
Total comments: 2
Patch Set 2 : remove libwebp block #Patch Set 3 : rebase #Patch Set 4 : reports as BSD-like after libwebp-0.3.1 #Messages
Total messages: 19 (0 generated)
Danny, can sanity check what's going into third_party/devscripts/licensecheck.pl ? Here's a sample file in question: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libweb... https://codereview.chromium.org/12771026/diff/1/tools/checklicenses/checklice... File tools/checklicenses/checklicenses.py (right): https://codereview.chromium.org/12771026/diff/1/tools/checklicenses/checklice... tools/checklicenses/checklicenses.py:288: 'BSD (3 clause)', Shouldn't you be able to remove this block? BSD (3 clause) is already in WHITELISTED_LICENSES.
https://codereview.chromium.org/12771026/diff/1/tools/checklicenses/checklice... File tools/checklicenses/checklicenses.py (right): https://codereview.chromium.org/12771026/diff/1/tools/checklicenses/checklice... tools/checklicenses/checklicenses.py:288: 'BSD (3 clause)', On 2013/03/22 02:16:04, Lei Zhang wrote: > Shouldn't you be able to remove this block? BSD (3 clause) is already in > WHITELISTED_LICENSES. Oh yes, I wasn't thinking of the use of the list when I made the edit...
On 2013/03/22 02:16:04, Lei Zhang wrote: > Danny, can sanity check what's going into third_party/devscripts/licensecheck.pl > ? > ping. > Here's a sample file in question: > https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libweb... > > https://codereview.chromium.org/12771026/diff/1/tools/checklicenses/checklice... > File tools/checklicenses/checklicenses.py (right): > > https://codereview.chromium.org/12771026/diff/1/tools/checklicenses/checklice... > tools/checklicenses/checklicenses.py:288: 'BSD (3 clause)', > Shouldn't you be able to remove this block? BSD (3 clause) is already in > WHITELISTED_LICENSES.
Danny, ping.
Sorry, if you add me directly, rather than through open-source-third-party-reviews, it basically ends up in a black hole, so I didn't see this until now. On Wed, Jun 5, 2013 at 5:02 PM, <thestig@chromium.org> wrote: > Danny, ping. > > https://codereview.chromium.**org/12771026/<https://codereview.chromium.org/1... >
On 2013/06/06 00:02:27, Lei Zhang wrote: > Danny, ping. Ugh. It's fine, but they never should have done this, I don't know who told them to use that license block, but it's just wrong.
On 2013/06/06 00:12:35, Daniel Berlin wrote: > I don't know who told them to > use that license block, Me neither, I'll ask around. > but it's just wrong. So moving forward, swap this with the actual text for webm/libvpx?
yes On Wed, Jun 5, 2013 at 10:30 PM, <jzern@chromium.org> wrote: > On 2013/06/06 00:12:35, Daniel Berlin wrote: > >> I don't know who told them to >> use that license block, >> > > Me neither, I'll ask around. > > > but it's just wrong. >> > > So moving forward, swap this with the actual text for webm/libvpx? > > > > https://codereview.chromium.**org/12771026/<https://codereview.chromium.org/1... >
After libwebp-0.3.1 [1] the sources are now reported as BSD-like. So all that remains is dropping the UNKNOWN block for libwebp. [1] https://chromiumcodereview.appspot.com/16871017
Can you update the CL description? Otherwise lgtm!
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jzern@chromium.org/12771026/17001
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jzern@chromium.org/12771026/17001
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jzern@chromium.org/12771026/17001
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jzern@chromium.org/12771026/17001
Message was sent while issue was closed.
Change committed as 209261 |
