Instant: Make clicks on Most Visited items work.

chrome/renderer/resources/extensions/searchbox_api.js

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var chrome;
 if (!chrome)
   chrome = {};
 
 if (!chrome.embeddedSearch) {
   chrome.embeddedSearch = new function() {
 
     // =========================================================================
     //                            Private functions
     // =========================================================================
     native function GetFont();
+    // DEPRECATED. TODO(sreeram): Remove once google.com no longer uses this.
     native function NavigateContentWindow();
 
     function escapeHTML(text) {
       return text.replace(/[<>&"']/g, function(match) {
         switch (match) {
           case '<': return '&lt;';
           case '>': return '&gt;';
           case '&': return '&amp;';
           case '"': return '&quot;';
           case "'": return '&apos;';
@@ skipping 31 matching lines @@
       // |embeddedSearchOnWindowReady| is used for initializing window context
       // and should be called only once per context.
       safeObjects.createShadowRoot = Element.prototype.webkitCreateShadowRoot;
       safeObjects.defineProperty = Object.defineProperty;
       delete window.chrome.embeddedSearchOnWindowReady;
     };
 
     // =========================================================================
     //                           Exported functions
     // =========================================================================
+    // DEPRECATED. TODO(sreeram): Remove once google.com no longer uses this.
     this.navigateContentWindow = function(destination, disposition) {
       return NavigateContentWindow(destination, disposition);
     };
 
     this.searchBox = new function() {
 
       // =======================================================================
       //                                  Constants
       // =======================================================================
       var MAX_CLIENT_SUGGESTIONS_TO_DEDUPE = 6;
@@ skipping 18 matching lines @@
       native function IsKeyCaptureEnabled();
       native function SetSuggestions();
       native function SetQuerySuggestion();
       native function SetQuerySuggestionFromAutocompleteResult();
       native function SetQuery();
       native function SetQueryFromAutocompleteResult();
       native function ShowOverlay();
       native function FocusOmnibox();
       native function StartCapturingKeyStrokes();
       native function StopCapturingKeyStrokes();
+      native function NavigateSearchBox();
 
       function SafeWrapSuggestion(restrictedText) {
         return SafeWrap(restrictedText, window.innerWidth - 155, 22);
       }
 
       // Wraps the AutocompleteResult query and URL into ShadowDOM nodes so that
       // the JS cannot access them and deletes the raw values.
       function GetAutocompleteResultsWrapper() {
         var autocompleteResults = DedupeAutocompleteResults(
             GetAutocompleteResults());
@@ skipping 117 matching lines @@
       this.__defineGetter__('displayInstantResults', GetDisplayInstantResults);
       this.__defineGetter__('font', GetFont);
       this.__defineGetter__('fontSize', GetFontSize);
 
       this.setSuggestions = function(text) {
         SetSuggestions(text);
       };
       this.setAutocompleteText = function(text, behavior) {
         SetQuerySuggestion(text, behavior);
       };
-      this.setRestrictedAutocompleteText = function(resultId) {
-        SetQuerySuggestionFromAutocompleteResult(resultId);
+      this.setRestrictedAutocompleteText = function(autocompleteResultId) {
+        SetQuerySuggestionFromAutocompleteResult(autocompleteResultId);
       };
       this.setValue = function(text, type) {
         SetQuery(text, type);
       };
-      this.setRestrictedValue = function(resultId) {
-        SetQueryFromAutocompleteResult(resultId);
+      this.setRestrictedValue = function(autocompleteResultId) {
+        SetQueryFromAutocompleteResult(autocompleteResultId);
       };
       // TODO(jered): Remove the deprecated "reason" argument.
       this.showOverlay = function(reason, height) {
         ShowOverlay(reason, height);
       };
       // TODO(jered): Remove this when GWS knows about showOverlay().
       this.show = this.showOverlay;
       this.markDuplicateSuggestions = function(clientSuggestions) {
         return DedupeClientSuggestions(clientSuggestions);
       };
       this.focus = function() {
         FocusOmnibox();
       };
       this.startCapturingKeyStrokes = function() {
         StartCapturingKeyStrokes();
       };
       this.stopCapturingKeyStrokes = function() {
         StopCapturingKeyStrokes();
       };
+      this.navigateContentWindow = function(destination, disposition) {
+        NavigateSearchBox(destination, disposition);
+      }
       this.onchange = null;
       this.onsubmit = null;
       this.oncancel = null;
       this.onresize = null;
       this.onkeypress = null;
       this.onkeycapturechange = null;
       this.oncontextchange = null;
       this.onmarginchange = null;
       this.onnativesuggestions = null;
 
@@ skipping 12 matching lines @@
     this.newTabPage = new function() {
 
       // =======================================================================
       //                            Private functions
       // =======================================================================
       native function GetMostVisitedItems();
       native function GetThemeBackgroundInfo();
       native function DeleteMostVisitedItem();
       native function UndoAllMostVisitedDeletions();
       native function UndoMostVisitedDeletion();
+      native function NavigateNewTabPage();
 
       function SafeWrapMostVisited(restrictedText, width, opt_direction) {
         return SafeWrap(restrictedText, width, 18, 11, opt_direction);
       }
 
       function GetMostVisitedItemsWrapper() {
         var mostVisitedItems = GetMostVisitedItems();
         for (var i = 0, item; item = mostVisitedItems[i]; ++i) {
           var title = escapeHTML(item.title);
           var domain = escapeHTML(item.domain);
@@ skipping 14 matching lines @@
 
       this.deleteMostVisitedItem = function(restrictId) {
         DeleteMostVisitedItem(restrictId);
       };
       this.undoAllMostVisitedDeletions = function() {
         UndoAllMostVisitedDeletions();
       };
       this.undoMostVisitedDeletion = function(restrictId) {
         UndoMostVisitedDeletion(restrictId);
       };
+      this.navigateContentWindow = function(destination, disposition) {
+        NavigateNewTabPage(destination, disposition);
+      }
 
       this.onmostvisitedchange = null;
       this.onthemechange = null;
     };
 
     // Export legacy searchbox API.
     // TODO: Remove this when Instant Extended is fully launched.
     chrome.searchBox = this.searchBox;
   };
 }