Implement java-side browser sensor polling for device motion and device orientation DOM events.

content/browser/device_orientation/data_fetcher_impl_android.h

Index: content/browser/device_orientation/data_fetcher_impl_android.h
diff --git a/content/browser/device_orientation/data_fetcher_impl_android.h b/content/browser/device_orientation/data_fetcher_impl_android.h
index cbcb363bfaac37cc17de14efc57d1aa83347936a..0911c3388b3f4888ce4671916f2d21a22de645ac 100644
--- a/content/browser/device_orientation/data_fetcher_impl_android.h
+++ b/content/browser/device_orientation/data_fetcher_impl_android.h
@@ -38,6 +38,15 @@ class DataFetcherImplAndroid : public DataFetcher {
   void GotOrientation(JNIEnv*, jobject,
                       double alpha, double beta, double gamma);
 
+  void GotAcceleration(JNIEnv*, jobject,

[Peter Beverloo, 2013/03/11 17:57:25]

For clarity, I'd prefer to either remove the empty lines between these four
methods *or* add the "Called from Java via JNI." comment above all of them,
given that it applies to all.

[timvolodine1, 2013/03/12 11:18:06]

Done.

+                      double x, double y, double z);

[Peter Beverloo, 2013/03/11 17:57:25]

nit: indent should be equal to JNIEnv* on line 41.

[timvolodine1, 2013/03/12 11:18:06]

Done.

+
+  void GotAccelerationIncludingGravity(JNIEnv*, jobject,
+                      double x, double y, double z);

[Peter Beverloo, 2013/03/11 17:57:25]

nit: indent should be equal to JNIEnv* on line 45.

[timvolodine1, 2013/03/12 11:18:06]

Done.

+
+  void GotRotationRate(JNIEnv*, jobject,
+                      double alpha, double beta, double gamma);

[Peter Beverloo, 2013/03/11 17:57:25]

nit: indent should be equal to JNIEnv* on line 47.

[timvolodine1, 2013/03/12 11:18:06]

Done.

+
   // Implementation of DataFetcher.
   virtual const DeviceData* GetDeviceData(DeviceData::Type type) OVERRIDE;
 
@@ -47,7 +56,10 @@ class DataFetcherImplAndroid : public DataFetcher {
 
   // Wrappers for JNI methods.
   bool Start(int rate_in_milliseconds);
+  bool Start(int spec_event_type, int rate_in_milliseconds);

[Peter Beverloo, 2013/03/11 17:57:25]

I'm not fond of having an int as the parameter, it's unreadable. Can we add an
enum to represent which event type should start polling?

[Peter Beverloo, 2013/03/11 17:57:25]

naming nit: I don't like "spec_event_type", as the "spec_" prefix doesn't add
any value.  When we have an enum, maybe just "event_type"?

[Miguel Garcia, 2013/03/11 18:25:50]

Yeah let's with an enum on C++ on Java we should keep int constants since enums
are expensive.

On 2013/03/11 17:57:25, Peter Beverloo wrote:

[timvolodine1, 2013/03/12 11:18:06]

Done.

[timvolodine1, 2013/03/12 11:18:06]

Done.

[timvolodine1, 2013/03/12 11:18:06]

Done.

+
   void Stop();

[Miguel Garcia, 2013/03/11 18:25:50]

I am not too fond on method overrides, but if deemed necessary please add a big
bunch of documentation explaining both cases.

[timvolodine1, 2013/03/12 11:18:06]

Done.

+  void Stop(int spec_event_type);
 
   // Value returned by GetDeviceData.
   scoped_refptr<Orientation> current_orientation_;