Issue 12771003: Revert 187283

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12771003: Revert 187283 (Closed)

Created:
7 years, 9 months ago by reed1

Modified:
7 years, 9 months ago

Reviewers:
reed1

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 187283 memcheck reported errors which need to be investigated > Call version of SkFontHost_fontconfig in Skia (cloned from here). > Retool the direct/remove plumbing to use SkFontConfigInterface. > > This change allows Skia to interate on the details of SkFontHost w/o having > to synchromize with chrome on each change. It also means Skia's internal testing > can exercise exactly the same config that Chrome does. > Review URL: https://codereview.chromium.org/12391070 TBR=reed@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187287

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+103 lines, -175 lines)			Patch
M	content/browser/renderer_host/render_sandbox_host_linux.cc	View	6 chunks	+48 lines, -40 lines	0 comments	Download
M	content/common/font_config_ipc_linux.h	View	2 chunks	+12 lines, -13 lines	0 comments	Download
M	content/common/font_config_ipc_linux.cc	View	5 chunks	+41 lines, -29 lines	0 comments	Download
M	content/zygote/zygote_main_linux.cc	View	3 chunks	+5 lines, -5 lines	0 comments	Download
A +	skia/ext/SkFontHost_fontconfig.cpp	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	skia/ext/SkFontHost_fontconfig_control.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	skia/ext/SkFontHost_fontconfig_direct.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	skia/ext/SkFontHost_fontconfig_direct.cpp	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	skia/ext/SkFontHost_fontconfig_impl.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	skia/ext/skia_utils_base.h	View	1 chunk	+0 lines, -33 lines	0 comments	Download
D	skia/ext/skia_utils_base.cc	View	1 chunk	+0 lines, -53 lines	0 comments	Download
M	skia/skia.gyp	View	2 chunks	+2 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r187287.

Expand Messages | Collapse Messages