Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1277043002: XFA: clang-format all pdfium code, again. (Closed)

Created:
5 years, 4 months ago by Nico
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

XFA: clang-format all pdfium code, again. Also add a presubmit that checks for this so I don't have to keep doing it. No behavior change. Generated by: find . -name '*.cpp' -o -name '*.h' | \ grep -E -v 'third_party|thirdparties|lpng_v163|tiff_v403' | \ xargs ../../buildtools/mac/clang-format -i Then manually merged https://codereview.chromium.org/1269223002/ See thread "tabs vs spaces" on pdfium@googlegroups.com for discussion. BUG=none R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/077f1a335560a8014e466c768c1e9d24c8a61ac9

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+412 lines, -531 lines) Patch
A PRESUBMIT.py View 1 chunk +14 lines, -0 lines 0 comments Download
M core/include/fpdfapi/fpdf_objects.h View 2 chunks +2 lines, -6 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 6 chunks +20 lines, -17 lines 0 comments Download
M core/src/fpdfdoc/doc_vt.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/extension.h View 3 chunks +5 lines, -16 lines 0 comments Download
M core/src/fxge/agg/src/fx_agg_driver.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M core/src/fxge/dib/fx_dib_engine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/ge/text_int.h View 1 chunk +4 lines, -2 lines 0 comments Download
M core/src/fxge/skia/fx_skia_device.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/fsdk_baseform.h View 1 chunk +11 lines, -11 lines 0 comments Download
M fpdfsdk/include/fxedit/fxet_list.h View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Define.h View 3 chunks +7 lines, -7 lines 0 comments Download
M fpdfsdk/include/javascript/app.h View 3 chunks +0 lines, -86 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Wnd.h View 1 chunk +21 lines, -21 lines 0 comments Download
M fpdfsdk/src/fpdf_flatten.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M fpdfsdk/src/fpdf_transformpage.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M fpdfsdk/src/fpdfeditimg.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M fpdfsdk/src/fsdk_annothandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 2 chunks +2 lines, -8 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_ap.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M fpdfsdk/src/javascript/app.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ListBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M public/fpdf_formfill.h View 2 chunks +3 lines, -2 lines 0 comments Download
M xfa/include/fwl/core/fwl_note.h View 1 chunk +14 lines, -14 lines 0 comments Download
M xfa/src/fee/src/fee/fde_txtedtengine.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_datetimepickerimp.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_monthcalendarimp.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/src/fxbarcode/BC_BarCode.cpp View 9 chunks +17 lines, -17 lines 1 comment Download
M xfa/src/fxbarcode/common/BC_CommonPerspectiveTransform.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixVersion.cpp View 1 chunk +58 lines, -58 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixWriter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_SymbolInfo.cpp View 1 chunk +7 lines, -14 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417BoundingBox.cpp View 4 chunks +7 lines, -9 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417DetectionResultRowIndicatorColumn.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417Detector.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417ECModulusGF.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417ECModulusPoly.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417ScanningDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRAlignmentPatternFinder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderEncoder.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderMode.cpp View 2 chunks +5 lines, -6 lines 0 comments Download
M xfa/src/fxbarcode/qrcode/BC_QRCoderVersion.cpp View 2 chunks +128 lines, -128 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffdocview.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffpushbutton.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxfa/src/fm2js/xfa_fmparse.cpp View 11 chunks +18 lines, -21 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_layout_itemlayout.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_object_imp.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_parser_imp.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Nico
Many of these files have dos line endings :-/ https://codereview.chromium.org/1277043002/diff/1/xfa/src/fxbarcode/BC_BarCode.cpp File xfa/src/fxbarcode/BC_BarCode.cpp (right): https://codereview.chromium.org/1277043002/diff/1/xfa/src/fxbarcode/BC_BarCode.cpp#newcode177 xfa/src/fxbarcode/BC_BarCode.cpp:177: ...
5 years, 4 months ago (2015-08-06 21:52:00 UTC) #2
Lei Zhang
rs lgtm I only spot checked.
5 years, 4 months ago (2015-08-06 22:01:56 UTC) #3
Nico
5 years, 4 months ago (2015-08-06 22:05:38 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
077f1a335560a8014e466c768c1e9d24c8a61ac9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698