Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Issue 1277013005: Images from content:url() aren't loading if the alt attribute is present (Closed)

Created:
5 years, 4 months ago by rhogan
Modified:
5 years, 4 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-html_chromium.org, blink-reviews-rendering, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Images from content:url() aren't loading if the alt attribute is present This is a second attempt at supporting fallback content on images that use content: to provide image data. The first attempt was https://codereview.chromium.org/1134903002. With this patch when we have this markup: <style> #img {content:url('resources/non-existent.png')} </style> <img id='img' alt='test image'> we will first load the image from the content:url() while parsing the style info. Then when we attach the element to the DOM we will create a layout object for it. Eventually the image will fail to load and will notify imageChanged(), which will reattach it and mark the element to load fallback content. A separate image load will happen for the img element and when that finds there's no src attribute it will also attempt to reattach the element for fallback content - but it will return early when it finds the element is already displaying fallback content. BUG=516239 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200510

Patch Set 1 #

Patch Set 2 : Updated #

Total comments: 2

Patch Set 3 : Updated #

Messages

Total messages: 7 (3 generated)
rhogan
5 years, 4 months ago (2015-08-11 19:26:15 UTC) #2
pdr.
Soo many edge cases :/ LGTM https://codereview.chromium.org/1277013005/diff/20001/LayoutTests/fast/images/content-url-broken-image-with-alt-text.html File LayoutTests/fast/images/content-url-broken-image-with-alt-text.html (right): https://codereview.chromium.org/1277013005/diff/20001/LayoutTests/fast/images/content-url-broken-image-with-alt-text.html#newcode3 LayoutTests/fast/images/content-url-broken-image-with-alt-text.html:3: #img {content:url('resources/lena.png')} Lets ...
5 years, 4 months ago (2015-08-11 20:48:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1277013005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1277013005/40001
5 years, 4 months ago (2015-08-13 20:29:24 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 02:01:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200510

Powered by Google App Engine
This is Rietveld 408576698